Re: [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

["Grant Likely" <grant.likely@secretlab.ca>]

On 6/12/07, Peter Korsgaard <jacmet@sunsite.dk> wrote:
> >>>>> "Grant" == Grant Likely <grant.likely@secretlab.ca> writes:
>
> Hi,
>
>  Grant> Rather than c67x00-hub.c being compiled seperately, the
>  Grant> original code had c67x00-hub.c *included* by c67x00-hcd.c.
>  Grant> This is a very bad idea.  Simplest solution is to merge the
>  Grant> two files into one and be done with it.
>
> Yeah, it isn't exactly pretty, but it's what the other hcd drivers do,
> E.G.:
>
> % grep -rs "include.*hub.c" *c
> ehci-hcd.c:#include "ehci-hub.c"
> ohci-hcd.c:#include "ohci-hub.c"
> uhci-hcd.c:#include "uhci-hub.c"
>
> I don't quite know why they do it like that though ..

True, but that doesn't mean that it's a good idea to follow the lead.
There are lots of other examples of ugly code in the kernel that is
tolerated just because nobody has cleaned it up yet, but is still
unacceptable for new code.

We know it's an ugly thing to do, and the fix is simple and easy.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195