Re: [linux-usb-devel] [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

["Grant Likely" <grant.likely@secretlab.ca>]

On 6/13/07, phil culler <phil.culler@gmail.com> wrote:
>
> On 6/13/07, Grant Likely <grant.likely@secretlab.ca> wrote:
> > On 6/12/07, Peter Korsgaard <jacmet@sunsite.dk> wrote:
> > > >>>>> "Grant" == Grant Likely <grant.likely@secretlab.ca > writes:
> > >
> > > Hi,
> > >
> > >  Grant> Rather than c67x00-hub.c being compiled seperately, the
> > >  Grant> original code had c67x00-hub.c *included* by c67x00-hcd.c.
> > >  Grant> This is a very bad idea.  Simplest solution is to merge the
> > >  Grant> two files into one and be done with it.
>
>
> > Hi Guys,
> > I'm currently implementing the gadget API for the c67x00 (specifically
> CY7C63200) and have several questions.
> >
> > 1. Are you aware of any others working on the gadget API for this driver?

Other than the skeleton that Peter wrote, No.  However, Peter has done
much of the low level work that is shared between HCD and Gadget.  You
need to look at his patchset.

http://thread.gmane.org/gmane.linux.usb.devel/53285

> > 2. I'm doing this on an embedded device (Xilinix/PPC) with no hardware DMA
> and on top of MontaVista 4.01 (2.6.10-kernel). I'd prefer to develop on a
> current kernel using something like a PCI card. Can you recommend a
> reasonably-priced development platform for the c67x00?

Hmm, I don't know.  I don't know of any.  I'm doing all my devel on an
ml403.  Check with Cypress.  I think they have an ARM based
development kit for the c67x00.

> > 3. Any suggestions about preventing additional ugly code? I'm adding the
> bulk of the API in c67x00-udc.c

Yes, post your patches to the list so so others can comment.  That's
the best way to find out if you're taking a bad approach.  Also,
follow the Linux kernel coding convention and run your code through
scripts/Lindent

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195