From: "Grant Likely" <grant.likely@secretlab.ca>
To: "John Rigby" <jcrigby@gmail.com>
Cc: linuxppc-dev@ozlabs.org, leoli@freescale.com, paulus@samba.org,
Timur Tabi <timur@freescale.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] Add USB support to mpc8349-mitx board port
Date: Sat, 7 Jul 2007 18:48:54 -0600 [thread overview]
Message-ID: <fa686aa40707071748g7f00f4c7jb761cceb7d72456d@mail.gmail.com> (raw)
In-Reply-To: <4b73d43f0707071734yeedd7e6g53101d45fbec899e@mail.gmail.com>
On 7/7/07, John Rigby <jcrigby@gmail.com> wrote:
> > This same comment probably goes for the other arch_initcall functions
> > in fsl_soc.c which do exactly the same thing for other devices.
>
> This depends, some devices in fsl_soc.c may exist on non-powerpc SoCs
> that do not have OF. The USB core in 8349 for example also is in the
> arm based mx27 and mx31. These devices should remain platform devices
> and the glue in fls_soc.c will continure to be needed.
I disagree; the current method is "glue for the glue". There is no
reason why the driver cannot have two bindings; one for
platform_device and one for of_platform_device. It's about the same
amount of code, but uses less indirection for the device tree case.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-07-08 0:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 22:29 [PATCH] Add USB support to mpc8349-mitx board port Grant Likely
2007-07-06 23:48 ` Arnd Bergmann
2007-07-07 5:46 ` Grant Likely
2007-07-08 0:34 ` John Rigby
2007-07-08 0:48 ` Grant Likely [this message]
2007-07-09 3:55 ` John Rigby
2007-07-09 17:03 ` Grant Likely
2007-07-09 23:35 ` John Rigby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40707071748g7f00f4c7jb761cceb7d72456d@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=arnd@arndb.de \
--cc=jcrigby@gmail.com \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).