* [PATCH] xilinxfb: Parameterize xilinxfb platform device registration
@ 2007-07-09 23:51 Grant Likely
2007-07-10 8:34 ` Andrei Konovalov
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2007-07-09 23:51 UTC (permalink / raw)
To: linuxppc-dev, paulus
From: Grant Likely <grant.likely@secretlab.ca>
This patch allows multiple xilinxfb devices to be registered and used
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
cc: Andrei Konovalov <akonovalov@ru.mvista.com>
---
arch/ppc/syslib/virtex_devices.c | 38 +++++++++++++++++++++++++-------------
1 files changed, 25 insertions(+), 13 deletions(-)
diff --git a/arch/ppc/syslib/virtex_devices.c b/arch/ppc/syslib/virtex_devices.c
index 83f978f..9b473cf 100644
--- a/arch/ppc/syslib/virtex_devices.c
+++ b/arch/ppc/syslib/virtex_devices.c
@@ -152,6 +152,21 @@
}, \
}
+/*
+ * ML300/ML403 Video Device: shortcut macro for single instance
+ */
+#define XPAR_TFT(num) { \
+ .name = "xilinxfb", \
+ .id = num, \
+ .num_resources = 1, \
+ .resource = (struct resource[]) { \
+ { \
+ .start = XPAR_TFT_##num##_BASEADDR, \
+ .end = XPAR_TFT_##num##_BASEADDR+7, \
+ .flags = IORESOURCE_IO, \
+ }, \
+ }, \
+}
/* UART 8250 driver platform data table */
struct plat_serial8250_port virtex_serial_platform_data[] = {
@@ -274,20 +289,17 @@ struct platform_device virtex_platform_devices[] = {
#endif
#endif
- /* ML300/403 reference design framebuffer */
#if defined(XPAR_TFT_0_BASEADDR)
- {
- .name = "xilinxfb",
- .id = 0,
- .num_resources = 1,
- .resource = (struct resource[]) {
- {
- .start = XPAR_TFT_0_BASEADDR,
- .end = XPAR_TFT_0_BASEADDR+7,
- .flags = IORESOURCE_IO,
- },
- },
- },
+ XPAR_TFT(0),
+#endif
+#if defined(XPAR_TFT_1_BASEADDR)
+ XPAR_TFT(1),
+#endif
+#if defined(XPAR_TFT_2_BASEADDR)
+ XPAR_TFT(2),
+#endif
+#if defined(XPAR_TFT_3_BASEADDR)
+ XPAR_TFT(3),
#endif
};
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xilinxfb: Parameterize xilinxfb platform device registration
2007-07-09 23:51 [PATCH] xilinxfb: Parameterize xilinxfb platform device registration Grant Likely
@ 2007-07-10 8:34 ` Andrei Konovalov
2007-07-10 14:56 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Andrei Konovalov @ 2007-07-10 8:34 UTC (permalink / raw)
To: Grant Likely; +Cc: linuxppc-dev, paulus
Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> This patch allows multiple xilinxfb devices to be registered and used
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> cc: Andrei Konovalov <akonovalov@ru.mvista.com>
> ---
Looks OK for me.
Thanks,
Andrei
> arch/ppc/syslib/virtex_devices.c | 38 +++++++++++++++++++++++++-------------
> 1 files changed, 25 insertions(+), 13 deletions(-)
>
> diff --git a/arch/ppc/syslib/virtex_devices.c b/arch/ppc/syslib/virtex_devices.c
> index 83f978f..9b473cf 100644
> --- a/arch/ppc/syslib/virtex_devices.c
> +++ b/arch/ppc/syslib/virtex_devices.c
> @@ -152,6 +152,21 @@
> }, \
> }
>
> +/*
> + * ML300/ML403 Video Device: shortcut macro for single instance
> + */
> +#define XPAR_TFT(num) { \
> + .name = "xilinxfb", \
> + .id = num, \
> + .num_resources = 1, \
> + .resource = (struct resource[]) { \
> + { \
> + .start = XPAR_TFT_##num##_BASEADDR, \
> + .end = XPAR_TFT_##num##_BASEADDR+7, \
> + .flags = IORESOURCE_IO, \
> + }, \
> + }, \
> +}
>
> /* UART 8250 driver platform data table */
> struct plat_serial8250_port virtex_serial_platform_data[] = {
> @@ -274,20 +289,17 @@ struct platform_device virtex_platform_devices[] = {
> #endif
> #endif
>
> - /* ML300/403 reference design framebuffer */
> #if defined(XPAR_TFT_0_BASEADDR)
> - {
> - .name = "xilinxfb",
> - .id = 0,
> - .num_resources = 1,
> - .resource = (struct resource[]) {
> - {
> - .start = XPAR_TFT_0_BASEADDR,
> - .end = XPAR_TFT_0_BASEADDR+7,
> - .flags = IORESOURCE_IO,
> - },
> - },
> - },
> + XPAR_TFT(0),
> +#endif
> +#if defined(XPAR_TFT_1_BASEADDR)
> + XPAR_TFT(1),
> +#endif
> +#if defined(XPAR_TFT_2_BASEADDR)
> + XPAR_TFT(2),
> +#endif
> +#if defined(XPAR_TFT_3_BASEADDR)
> + XPAR_TFT(3),
> #endif
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xilinxfb: Parameterize xilinxfb platform device registration
2007-07-10 8:34 ` Andrei Konovalov
@ 2007-07-10 14:56 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2007-07-10 14:56 UTC (permalink / raw)
To: Andrei Konovalov; +Cc: linuxppc-dev, paulus
On 7/10/07, Andrei Konovalov <akonovalov@ru.mvista.com> wrote:
> Grant Likely wrote:
> > From: Grant Likely <grant.likely@secretlab.ca>
> >
> > This patch allows multiple xilinxfb devices to be registered and used
> >
> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > cc: Andrei Konovalov <akonovalov@ru.mvista.com>
> > ---
>
> Looks OK for me.
Paulus, can you please pick this one up?
Thanks,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-10 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-09 23:51 [PATCH] xilinxfb: Parameterize xilinxfb platform device registration Grant Likely
2007-07-10 8:34 ` Andrei Konovalov
2007-07-10 14:56 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).