BUG: compile failure on ps3-head.S

BUG: compile failure on ps3-head.S

[Grant Likely]

commit id bafdb645779c63300763acb383f7b9dd2d427228 (on Linus' tree)
causes breakage on my mpc8349 build (see below).  I've worked around
it by removing ps3* from arch/powerpc/boot/Makefile, but I have not
dug into what the 'proper' solution should be.

Cheers,
g.

Toolchain: gcc version 4.0.0 (DENX ELDK 4.0 4.0.0)
Build command: make mpc834x_itxgp_defconfig; make zImage

make ARCH=ppc64 -f scripts/Makefile.build obj=arch/powerpc/boot
arch/powerpc/boot/zImage
  ppc_6xx-gcc -m32 -Wp,-MD,arch/powerpc/boot/.ps3-head.o.d
-D__ASSEMBLY__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs
-fno-strict-aliasing -Os -msoft-float -pipe -fomit-frame-pointer
-fno-builtin -fPIC -nostdinc -isystem
/home/opt/eldk-4.0/usr/bin/../lib/gcc/powerpc-linux/4.0.0/include
-traditional -nostdinc -c -o arch/powerpc/boot/ps3-head.o
arch/powerpc/boot/ps3-head.S
arch/powerpc/boot/ps3-head.S: Assembler messages:
arch/powerpc/boot/ps3-head.S:40: Error: Unrecognized opcode: `clrldi'
arch/powerpc/boot/ps3-head.S:41: Error: Unrecognized opcode: `mtmsrd'
make[1]: *** [arch/powerpc/boot/ps3-head.o] Error 1
make: *** [zImage] Error 2


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

Re: BUG: compile failure on ps3-head.S

[Segher Boessenkool]

> commit id bafdb645779c63300763acb383f7b9dd2d427228 (on Linus' tree)
> causes breakage on my mpc8349 build (see below).  I've worked around
> it by removing ps3* from arch/powerpc/boot/Makefile, but I have not
> dug into what the 'proper' solution should be.

> arch/powerpc/boot/ps3-head.S:40: Error: Unrecognized opcode: `clrldi'
> arch/powerpc/boot/ps3-head.S:41: Error: Unrecognized opcode: `mtmsrd'

Those source files just need a .machine pseudo-op somewhere.


Segher

PS3: Fix build with 32-bit toolchains

[Geoff Levand]

The PS3 bootwrapper files use instructions only available on
64-bit CPUs.  Add the code generation directive '.machine "ppc64"'
for toolchains configured for 32-bit CPUs.

Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
Paul,

Please apply for 2.6.23-rc1.

 arch/powerpc/boot/ps3-head.S   |    2 ++
 arch/powerpc/boot/ps3-hvcall.S |    2 ++
 2 files changed, 4 insertions(+)

--- a/arch/powerpc/boot/ps3-head.S
+++ b/arch/powerpc/boot/ps3-head.S
@@ -20,6 +20,8 @@
 
 #include "ppc_asm.h"
 
+	.machine "ppc64"
+
 	.text
 
 /*
--- a/arch/powerpc/boot/ps3-hvcall.S
+++ b/arch/powerpc/boot/ps3-hvcall.S
@@ -20,6 +20,8 @@
 
 #include "ppc_asm.h"
 
+	.machine "ppc64"
+
 /*
  * The PS3 hypervisor uses a 64 bit "C" language calling convention.
  * The routines here marshal arguments between the 32 bit wrapper

Re: PS3: Fix build with 32-bit toolchains

[Kumar Gala]

On Jul 19, 2007, at 4:47 PM, Geoff Levand wrote:

> The PS3 bootwrapper files use instructions only available on
> 64-bit CPUs.  Add the code generation directive '.machine "ppc64"'
> for toolchains configured for 32-bit CPUs.
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>

while this is a fix, why are we even building it Grant's case of  
building 834x itx.

- k

Re: PS3: Fix build with 32-bit toolchains

[Geoff Levand]

Kumar Gala wrote:
> On Jul 19, 2007, at 4:47 PM, Geoff Levand wrote:
> 
>> The PS3 bootwrapper files use instructions only available on
>> 64-bit CPUs.  Add the code generation directive '.machine "ppc64"'
>> for toolchains configured for 32-bit CPUs.
>>
>> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> 
> while this is a fix, why are we even building it Grant's case of  
> building 834x itx.

I originally had the makefile setup to conditionally build these
files on CONFIG_PPC_PS3, but during the review I was requested to
change it to build them unconditionally.  See:

  http://ozlabs.org/pipermail/linuxppc-dev/2007-June/038072.html

-Geoff

Re: PS3: Fix build with 32-bit toolchains

[Grant Likely]

On 7/19/07, Geoff Levand <geoffrey.levand@am.sony.com> wrote:
> The PS3 bootwrapper files use instructions only available on
> 64-bit CPUs.  Add the code generation directive '.machine "ppc64"'
> for toolchains configured for 32-bit CPUs.
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>

> ---
> Paul,
>
> Please apply for 2.6.23-rc1.
>
>  arch/powerpc/boot/ps3-head.S   |    2 ++
>  arch/powerpc/boot/ps3-hvcall.S |    2 ++
>  2 files changed, 4 insertions(+)
>
> --- a/arch/powerpc/boot/ps3-head.S
> +++ b/arch/powerpc/boot/ps3-head.S
> @@ -20,6 +20,8 @@
>
>  #include "ppc_asm.h"
>
> +       .machine "ppc64"
> +
>         .text
>
>  /*
> --- a/arch/powerpc/boot/ps3-hvcall.S
> +++ b/arch/powerpc/boot/ps3-hvcall.S
> @@ -20,6 +20,8 @@
>
>  #include "ppc_asm.h"
>
> +       .machine "ppc64"
> +
>  /*
>   * The PS3 hypervisor uses a 64 bit "C" language calling convention.
>   * The routines here marshal arguments between the 32 bit wrapper
>
>


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

PS3: Fix build with 32-bit toolchains

[Geoff Levand]

The PS3 bootwrapper files use instructions only available on
64-bit CPUs.  Add the code generation directive '.machine "ppc64"'
for toolchains configured for 32-bit CPUs.

Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
---
Hi Andrew,

It seems Paul is out on holiday, so I'm sending this to you.

This fixes a build error in Linus' current tree for a few
32 bit powerpc platforms.  It had some review on the
linuxppc-dev ML, and Grant Likely reported it fixed the
problem.

-Geoff

 arch/powerpc/boot/ps3-head.S   |    2 ++
 arch/powerpc/boot/ps3-hvcall.S |    2 ++
 2 files changed, 4 insertions(+)

--- a/arch/powerpc/boot/ps3-head.S
+++ b/arch/powerpc/boot/ps3-head.S
@@ -20,6 +20,8 @@
 
 #include "ppc_asm.h"
 
+	.machine "ppc64"
+
 	.text
 
 /*
--- a/arch/powerpc/boot/ps3-hvcall.S
+++ b/arch/powerpc/boot/ps3-hvcall.S
@@ -20,6 +20,8 @@
 
 #include "ppc_asm.h"
 
+	.machine "ppc64"
+
 /*
  * The PS3 hypervisor uses a 64 bit "C" language calling convention.
  * The routines here marshal arguments between the 32 bit wrapper