From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: Date: Thu, 19 Jul 2007 16:12:09 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Kim Phillips" Subject: Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path In-Reply-To: <20070719164036.f3d4c86d.kim.phillips@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <20070719183415.7458.42622.stgit@trillian> <20070719183734.7458.83695.stgit@trillian> <469FB47D.4030009@freescale.com> <20070719164036.f3d4c86d.kim.phillips@freescale.com> Cc: linuxppc-dev@ozlabs.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 7/19/07, Kim Phillips wrote: > On Thu, 19 Jul 2007 13:43:17 -0600 > "Grant Likely" wrote: > > > On 7/19/07, Scott Wood wrote: > > > Grant Likely wrote: > > > > From: Grant Likely > > > > > > > > To boot from a cuImage requires the device tree to have a > > > > linux,stdout-path property in the chosen node. This patch adds it > > > > to the .dts files. > > > > > > This will break many current u-boots, as they blindly add a /chosen node > > > regardless of whether one already exists. > > > > That really should be fixed then. In the meantime; I'll resubmit the > > patch to add the chosen node; but with it commented out. > > > > the old FLAT_TREE u-boot fdt fixup code renames any existing chosen > node out of the way, and adds its fixed up version as /chosen. > > The LIBFDT implementation replaces any existing /chosen with its fixed > up version. > > So it all works out. Adding chosen/linux,stdout-path properties to the > kernel dtses is fine. > > btw, why are these changes being limited to the ITX and GP? Simply because I'm working on an itx-gp board. If this is deemed to be a good change, I can whip up a patch to fix all boards with my 'best guess' as to what stdout should be. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195