From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Domen Puncer" <domen.puncer@telargo.com>
Cc: Linux PPC Mailing List <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: mpc5200 low power mode, .globl fix
Date: Fri, 20 Jul 2007 09:09:54 -0600 [thread overview]
Message-ID: <fa686aa40707200809n635d4203j719c26c3258b8da9@mail.gmail.com> (raw)
In-Reply-To: <20070720105550.GA1385@moe.telargo.com>
On 7/20/07, Domen Puncer <domen.puncer@telargo.com> wrote:
> flush_data_cache doesn't need to be global, and can cause problems.
> Thanks to Milton Miller for noticing this.
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Paulus, can you pick this up please?
> ---
> arch/powerpc/platforms/52xx/lite5200_sleep.S | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: work-powerpc.git/arch/powerpc/platforms/52xx/lite5200_sleep.S
> ===================================================================
> --- work-powerpc.git.orig/arch/powerpc/platforms/52xx/lite5200_sleep.S
> +++ work-powerpc.git/arch/powerpc/platforms/52xx/lite5200_sleep.S
> @@ -400,7 +400,6 @@ restore_regs:
> * Flush data cache
> * Do this by just reading lots of stuff into the cache.
> */
> - .globl flush_data_cache
> flush_data_cache:
> lis r3,CONFIG_KERNEL_START@h
> ori r3,r3,CONFIG_KERNEL_START@l
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
prev parent reply other threads:[~2007-07-20 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 20:32 [PATCH] powerpc: mpc5200 low power mode Sylvain Munaut
2007-07-20 10:55 ` [PATCH] powerpc: mpc5200 low power mode, .globl fix Domen Puncer
2007-07-20 15:09 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40707200809n635d4203j719c26c3258b8da9@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=domen.puncer@telargo.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).