From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.231]) by ozlabs.org (Postfix) with ESMTP id 38D01DDE9E for ; Sat, 21 Jul 2007 01:09:56 +1000 (EST) Received: by nz-out-0506.google.com with SMTP id l1so793939nzf for ; Fri, 20 Jul 2007 08:09:55 -0700 (PDT) Message-ID: Date: Fri, 20 Jul 2007 09:09:54 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Domen Puncer" Subject: Re: [PATCH] powerpc: mpc5200 low power mode, .globl fix In-Reply-To: <20070720105550.GA1385@moe.telargo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <11847043512142-git-send-email-tnt@246tNt.com> <20070720105550.GA1385@moe.telargo.com> Cc: Linux PPC Mailing List , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 7/20/07, Domen Puncer wrote: > flush_data_cache doesn't need to be global, and can cause problems. > Thanks to Milton Miller for noticing this. > > > Signed-off-by: Domen Puncer Signed-off-by: Grant Likely Paulus, can you pick this up please? > --- > arch/powerpc/platforms/52xx/lite5200_sleep.S | 1 - > 1 file changed, 1 deletion(-) > > Index: work-powerpc.git/arch/powerpc/platforms/52xx/lite5200_sleep.S > =================================================================== > --- work-powerpc.git.orig/arch/powerpc/platforms/52xx/lite5200_sleep.S > +++ work-powerpc.git/arch/powerpc/platforms/52xx/lite5200_sleep.S > @@ -400,7 +400,6 @@ restore_regs: > * Flush data cache > * Do this by just reading lots of stuff into the cache. > */ > - .globl flush_data_cache > flush_data_cache: > lis r3,CONFIG_KERNEL_START@h > ori r3,r3,CONFIG_KERNEL_START@l > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195