From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Domen Puncer" <domen.puncer@telargo.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] lite5200b: flash definition in dts
Date: Wed, 1 Aug 2007 06:41:04 -0600 [thread overview]
Message-ID: <fa686aa40708010541n4d4900cfv7042d6ca685416d1@mail.gmail.com> (raw)
In-Reply-To: <20070801065203.GK4529@moe.telargo.com>
On 8/1/07, Domen Puncer <domen.puncer@telargo.com> wrote:
> Add flash definition for to lite5200b dts, and while at it
> fix "ranges" for soc node.
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
>
> ---
> Hi!
>
> Sylvain, it would be nice to have this merged.
>
> # cat /proc/mtd
> dev: size erasesize name
> mtd0: 01000000 00020000 "data0"
> mtd1: 00f00000 00020000 "data1"
> mtd2: 00100000 00020000 "u-boot"
>
> Some benchmarks:
> read: 2.3 MB/s
> erase: 168 kB/s
> write: 7.3 kB/s
>
>
> arch/powerpc/boot/dts/lite5200b.dts | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> Index: work-powerpc.git/arch/powerpc/boot/dts/lite5200b.dts
> ===================================================================
> --- work-powerpc.git.orig/arch/powerpc/boot/dts/lite5200b.dts
> +++ work-powerpc.git/arch/powerpc/boot/dts/lite5200b.dts
> @@ -52,7 +52,8 @@
> revision = ""; // from bootloader
> #interrupt-cells = <3>;
> device_type = "soc";
> - ranges = <0 f0000000 f0010000>;
> + ranges = <00000000 f0000000 00010000
> + fe000000 fe000000 02000000>;
I don't think this is the right approach. I think the SoC node is
intended for describing the on-chip devices, and the ranges property
reflects that. Shouldn't flash nodes be up 1 level?
Cheers,
g.
> reg = <f0000000 00010000>;
> bus-frequency = <0>; // from bootloader
> system-frequency = <0>; // from bootloader
> @@ -403,5 +404,26 @@
> compatible = "mpc5200b-sram\0mpc5200-sram\0sram";
> reg = <8000 4000>;
> };
> +
> + flash@fe000000 {
> + device_type = "rom";
> + compatible = "direct-mapped";
> + probe-type = "CFI";
> + reg = <fe000000 01000000>;
> + bank-width = <1>;
> + partitions = <00000000 01000000>;
> + partition-names = "data0";
> + };
> +
> + flash@ff000000 {
> + device_type = "rom";
> + compatible = "direct-mapped";
> + probe-type = "CFI";
> + reg = <ff000000 01000000>;
> + bank-width = <1>;
> + partitions = <00000000 00f00000
> + 00f00000 00100000>;
> + partition-names = "data1", "u-boot";
> + };
> };
> };
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-08-01 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 9:54 [PATCH] lite5200b: flash definition in dts Domen Puncer
2007-08-01 6:52 ` Domen Puncer
2007-08-01 12:41 ` Grant Likely [this message]
2007-08-02 5:58 ` Domen Puncer
2007-08-02 6:23 ` Grant Likely
2007-08-02 16:56 ` Scott Wood
2007-08-07 7:02 ` [PATCH v2] " Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40708010541n4d4900cfv7042d6ca685416d1@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=domen.puncer@telargo.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).