From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Joachim Förster" <mls.JOFT@gmx.de>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: ML403 / ALSA driver for AC97 Controller
Date: Sun, 5 Aug 2007 08:19:21 -0600 [thread overview]
Message-ID: <fa686aa40708050719l2cfcb507y26e39b3e067e543c@mail.gmail.com> (raw)
In-Reply-To: <1186300813.5534.33.camel@localhost>
On 8/5/07, Joachim F=F6rster <mls.JOFT@gmx.de> wrote:
> tag v2.6.22 (Linus)
> branch master (Linus)
> branch virtex-dev (your v2.6.22 based branch)
>
> I had to make different patches, because one version didn't apply
> cleanly to the other branches, due to differences in a Kconfig file e.g.
> and above all in the virtex_devices.c file.
>
> Now, my question is: Which one should I post to the mailing list? (after
> testing these patches - I haven't got a chance yet to test them on real
> hardware - compilation is ok).
Post the one against master, ultimately that's where the code needs to
go. I'll take care of any conflicts with my tree, and v2.6.22 is
irrelevant (at least as far as getting things into mainline is
concerned). :-)
>
> One more thing: I made two parts, one patch adds the driver and the
> other one makes the registration with the platform bus. Is this ok? (I
> saw this scheme in your virtex-dev branch.)
Absolutely! Splitting it up into logical changes is the right way to do it=
.
> Meanwhile, I had a _very_ short look into ASoC ... and I don't really
> know ... My driver already uses the AC97 Layer of ALSA, so in some way
> the codec is already separated from the controller. Xilinx' AC97
> Controller Reference does have some very bad impact on the codec which
> forced me to implement codec register shadowing ... hmmmm, I have to
> look at it (ASoC) again - as soon as there is more (free)time ...
Heh, okay. I haven't dug into ASoC either, so I can't make too many commen=
ts.
Cheers,
g.
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-08-05 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 19:57 ML403 / ALSA driver for AC97 Controller Joachim Förster
2007-07-21 20:17 ` Grant Likely
2007-08-05 8:00 ` Joachim Förster
2007-08-05 14:19 ` Grant Likely [this message]
2007-08-05 14:20 ` Grant Likely
2007-08-08 22:16 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40708050719l2cfcb507y26e39b3e067e543c@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-embedded@ozlabs.org \
--cc=mls.JOFT@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).