From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.183]) by ozlabs.org (Postfix) with ESMTP id 87A8EDDD0A for ; Mon, 6 Aug 2007 00:19:22 +1000 (EST) Received: by wa-out-1112.google.com with SMTP id m28so1635642wag for ; Sun, 05 Aug 2007 07:19:21 -0700 (PDT) Message-ID: Date: Sun, 5 Aug 2007 08:19:21 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "=?ISO-8859-1?Q?Joachim_F=F6rster?=" Subject: Re: ML403 / ALSA driver for AC97 Controller In-Reply-To: <1186300813.5534.33.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1185047879.15040.34.camel@localhost> <1186300813.5534.33.camel@localhost> Cc: linuxppc-embedded@ozlabs.org List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 8/5/07, Joachim F=F6rster wrote: > tag v2.6.22 (Linus) > branch master (Linus) > branch virtex-dev (your v2.6.22 based branch) > > I had to make different patches, because one version didn't apply > cleanly to the other branches, due to differences in a Kconfig file e.g. > and above all in the virtex_devices.c file. > > Now, my question is: Which one should I post to the mailing list? (after > testing these patches - I haven't got a chance yet to test them on real > hardware - compilation is ok). Post the one against master, ultimately that's where the code needs to go. I'll take care of any conflicts with my tree, and v2.6.22 is irrelevant (at least as far as getting things into mainline is concerned). :-) > > One more thing: I made two parts, one patch adds the driver and the > other one makes the registration with the platform bus. Is this ok? (I > saw this scheme in your virtex-dev branch.) Absolutely! Splitting it up into logical changes is the right way to do it= . > Meanwhile, I had a _very_ short look into ASoC ... and I don't really > know ... My driver already uses the AC97 Layer of ALSA, so in some way > the codec is already separated from the controller. Xilinx' AC97 > Controller Reference does have some very bad impact on the codec which > forced me to implement codec register shadowing ... hmmmm, I have to > look at it (ASoC) again - as soon as there is more (free)time ... Heh, okay. I haven't dug into ASoC either, so I can't make too many commen= ts. Cheers, g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195