Re: [PATCH 1/2] Xlinx ML403 AC97 Controller Reference device driver

["Grant Likely" <grant.likely@secretlab.ca>]

On 8/9/07, Joachim F=F6rster <mls.JOFT@gmx.de> wrote:
> Hi Grant,
>
> On Thu, 2007-08-09 at 11:49 -0600, Grant Likely wrote:
> > > diff --git a/sound/ppc/Makefile b/sound/ppc/Makefile
> > > index eacee2d..827f2f5 100644
> > > --- a/sound/ppc/Makefile
> > > +++ b/sound/ppc/Makefile
> >
> > Couldn't this end up on MicroBlaze too?  If so, sound/ppc is the wrong =
place.
>
> Well, I don't know. The only arch depended calls I use (am aware of) are
> in/out_be32(), so this _might_ work for mb, too. (I won't be able to
> test that in the next few months ...)
>
> On Thu, 2007-08-09 at 11:17 -0700, Stephen Neuendorffer wrote:
> >  I second grant here... this should eventually work on microblaze, too,
> > so putting it drivers/ and using XILINX_DRIVERS instead of XILINX_VIRTE=
X
> > (based on the patch Wolfgang recently posted) would probably be prefera=
ble.
> >
> > > +
> > > +config SND_ML403_AC97CR
> > > +       tristate "Xilinx ML403 AC97 Controller Reference"
> > > +       depends on SND && XILINX_VIRTEX
> >
> > Steve
>
> So, like Stephen Neuendorffer said, I should move it to sound/drivers,
> right? Takashi?
>
>
> On Thu, 2007-08-09 at 11:49 -0600, Grant Likely wrote:
> > > +snd-ml403_ac97cr-objs :=3D ml403_ac97cr.o
> >
> > This line is only needed if you're compiling multiple .c files into one=
 .ko
>
> Ah, well, then I have to rename the main .c file. But all the other ALSA
> drivers seem to _not_ include the "snd-" in front of it (ok, except the
> new PS3 driver and maybe other new ones?)
>
> > I'll try adding your patches to my tree this afternoon.
>
> I made patch against your tree, too (like a said before). Tell me, then
> I post it ...

No, don't base against my tree.  You worry about mainline; I'll worry
about my tree.  :-)

My tree gets rebased periodically anyway, so it's a much harder target.

>
>  Joachim
>
>
>


--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195