From: "Grant Likely" <grant.likely@secretlab.ca>
To: "wolfgang.reissnegger@xilinx.com" <wolfgang.reissnegger@xilinx.com>
Cc: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>,
linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH 1/3] Add generic configuration option to enable all xilinx drivers.
Date: Tue, 21 Aug 2007 21:28:08 -0600 [thread overview]
Message-ID: <fa686aa40708212028n6dfe02fend98298fc945f063e@mail.gmail.com> (raw)
In-Reply-To: <20070822005048.BD4E4D800B8@mail60-blu.bigfish.com>
On 8/21/07, wolfgang.reissnegger@xilinx.com
<wolfgang.reissnegger@xilinx.com> wrote:
> From: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
>
> In the future, this will be used to provide similar configuration
> for PowerPC and Microblaze.
I'm not convinced that this change is worth it since there is only one
in-tree driver that uses it. I'd maintain it separately in your tree
until other drivers or the microblaze stuff is ready for merging.
<snip>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 518d5d3..e5bc9af 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -219,3 +219,13 @@ config THINKPAD_ACPI_INPUT_ENABLED
>
>
> endif # MISC_DEVICES
> +endmenu
Umm, this looks wrong. Where'd the 'endmenu' come from?
Cheers,
g
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-08-22 3:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 0:53 [PATCH 1/3] Add generic configuration option to enable all xilinx drivers wolfgang.reissnegger
2007-08-22 3:28 ` Grant Likely [this message]
2007-08-22 16:35 ` Stephen Neuendorffer
-- strict thread matches above, loose matches on Subject: below --
2007-08-22 0:31 Wolfgang Reissnegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40708212028n6dfe02fend98298fc945f063e@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-embedded@ozlabs.org \
--cc=stephen.neuendorffer@xilinx.com \
--cc=wolfgang.reissnegger@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).