[PATCH 1/3] Add generic configuration option to enable all xilinx drivers.

[PATCH 1/3] Add generic configuration option to enable all xilinx drivers.

[Wolfgang Reissnegger]

From: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>

In the future, this will be used to provide similar configuration
for PowerPC and Microblaze.

Signed-off-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Signed-off-by: Wolfgang Reissnegger <wolfgang.reissnegger@xilinx.com>
---
 arch/ppc/platforms/4xx/Kconfig |    1 +
 drivers/misc/Kconfig           |   10 ++++++++++
 drivers/video/Kconfig          |    2 +-
 3 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/arch/ppc/platforms/4xx/Kconfig b/arch/ppc/platforms/4xx/Kconfig
index 76551b6..d7db7e4 100644
--- a/arch/ppc/platforms/4xx/Kconfig
+++ b/arch/ppc/platforms/4xx/Kconfig
@@ -228,6 +228,7 @@ config XILINX_VIRTEX_4_FX
 
 config XILINX_VIRTEX
 	bool
+	select XILINX_DRIVERS
 
 config STB03xxx
 	bool
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 518d5d3..e5bc9af 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -219,3 +219,13 @@ config THINKPAD_ACPI_INPUT_ENABLED
 
 
 endif # MISC_DEVICES
+endmenu
+
+
+#
+# Xilinx devices and common device driver infrastructure
+#
+
+config XILINX_DRIVERS
+  bool
+
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 5216c11..69e7240 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1824,7 +1824,7 @@ config FB_PS3_DEFAULT_SIZE_M
 
 config FB_XILINX
 	tristate "Xilinx frame buffer support"
-	depends on FB && XILINX_VIRTEX
+	depends on FB && XILINX_DRIVERS
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-- 
1.5.2.1

[PATCH 1/3] Add generic configuration option to enable all xilinx drivers.

[wolfgang.reissnegger]

From: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>

In the future, this will be used to provide similar configuration
for PowerPC and Microblaze.

Signed-off-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Signed-off-by: Wolfgang Reissnegger <wolfgang.reissnegger@xilinx.com>
---
 arch/ppc/platforms/4xx/Kconfig |    1 +
 drivers/misc/Kconfig           |   10 ++++++++++
 drivers/video/Kconfig          |    2 +-
 3 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/arch/ppc/platforms/4xx/Kconfig b/arch/ppc/platforms/4xx/Kconfig
index 76551b6..d7db7e4 100644
--- a/arch/ppc/platforms/4xx/Kconfig
+++ b/arch/ppc/platforms/4xx/Kconfig
@@ -228,6 +228,7 @@ config XILINX_VIRTEX_4_FX
 
 config XILINX_VIRTEX
 	bool
+	select XILINX_DRIVERS
 
 config STB03xxx
 	bool
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 518d5d3..e5bc9af 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -219,3 +219,13 @@ config THINKPAD_ACPI_INPUT_ENABLED
 
 
 endif # MISC_DEVICES
+endmenu
+
+
+#
+# Xilinx devices and common device driver infrastructure
+#
+
+config XILINX_DRIVERS
+  bool
+
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 5216c11..69e7240 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1824,7 +1824,7 @@ config FB_PS3_DEFAULT_SIZE_M
 
 config FB_XILINX
 	tristate "Xilinx frame buffer support"
-	depends on FB && XILINX_VIRTEX
+	depends on FB && XILINX_DRIVERS
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-- 
1.5.2.1

Re: [PATCH 1/3] Add generic configuration option to enable all xilinx drivers.

[Grant Likely]

On 8/21/07, wolfgang.reissnegger@xilinx.com
<wolfgang.reissnegger@xilinx.com> wrote:
> From: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
>
> In the future, this will be used to provide similar configuration
> for PowerPC and Microblaze.

I'm not convinced that this change is worth it since there is only one
in-tree driver that uses it.  I'd maintain it separately in your tree
until other drivers or the microblaze stuff is ready for merging.

<snip>

> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 518d5d3..e5bc9af 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -219,3 +219,13 @@ config THINKPAD_ACPI_INPUT_ENABLED
>
>
>  endif # MISC_DEVICES
> +endmenu

Umm, this looks wrong.  Where'd the 'endmenu' come from?

Cheers,
g

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

RE: [PATCH 1/3] Add generic configuration option to enable all xilinx drivers.

[Stephen Neuendorffer]

=20

> -----Original Message-----
> From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On=20
> Behalf Of Grant Likely
> Sent: Tuesday, August 21, 2007 8:28 PM
> To: Wolfgang Reissnegger
> Cc: linuxppc-embedded@ozlabs.org; Stephen Neuendorffer
> Subject: Re: [PATCH 1/3] Add generic configuration option to=20
> enable all xilinx drivers.
>=20
> On 8/21/07, wolfgang.reissnegger@xilinx.com
> <wolfgang.reissnegger@xilinx.com> wrote:
> > From: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
> >
> > In the future, this will be used to provide similar configuration
> > for PowerPC and Microblaze.
>=20
> I'm not convinced that this change is worth it since there is only one
> in-tree driver that uses it.  I'd maintain it separately in your tree
> until other drivers or the microblaze stuff is ready for merging.

I have at least one more driver that will use it, for the ICAP, and
joachim's AC97 driver should use it too.

In any event, my intention with all of this is to start small to figure
out how
to do it...  Plus I think it will be much easier to manage our tree if
basic
changes like this are merged long before arch/microblaze.

Steve=20