From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.241]) by ozlabs.org (Postfix) with ESMTP id 356EDDDE9C for ; Fri, 31 Aug 2007 14:14:44 +1000 (EST) Received: by an-out-0708.google.com with SMTP id c37so127725anc for ; Thu, 30 Aug 2007 21:14:41 -0700 (PDT) Message-ID: Date: Thu, 30 Aug 2007 22:14:41 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Grant Likely" , linuxppc-dev@ozlabs.org, "Scott Wood" Subject: Re: [PATCH 1/3] bootwrapper: In cuImage, print message for ENET devices not found in tree In-Reply-To: <20070831024356.GA19271@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20070830202618.9927.32588.stgit@trillian.cg.shawcable.net> <20070831024356.GA19271@localhost.localdomain> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 8/30/07, David Gibson wrote: > On Thu, Aug 30, 2007 at 02:26:18PM -0600, Grant Likely wrote: > > From: Grant Likely > > > > Signed-off-by: Grant Likely > > CC: Scott Wood > > CC: Kumar Gala > > CC: David Gibson > > Hrm... I thought Scott had deliberately removed that message in his > patch set, to work with the way PlanetCore generates Ethernet > addresses. I'm confused then. The code either sets the property or it doesn't. >>From what I can see, the message doesn't make any sense in the context of *not* calling setprop(). How does PlanetCore work? Scott? g. > > > --- > > > > arch/powerpc/boot/devtree.c | 14 +++++++------- > > 1 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/arch/powerpc/boot/devtree.c b/arch/powerpc/boot/devtree.c > > index e1b8122..8451a1c 100644 > > --- a/arch/powerpc/boot/devtree.c > > +++ b/arch/powerpc/boot/devtree.c > > @@ -99,14 +99,14 @@ void __dt_fixup_mac_addresses(u32 startindex, ...) > > while ((addr = va_arg(ap, const u8 *))) { > > devp = find_node_by_prop_value(NULL, "linux,network-index", > > (void*)&index, sizeof(index)); > > - > > - printf("ENET%d: local-mac-address <-" > > - " %02x:%02x:%02x:%02x:%02x:%02x\n\r", index, > > - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]); > > - > > - if (devp) > > + if (devp) { > > + printf("ENET%d: local-mac-address <-" > > + " %02x:%02x:%02x:%02x:%02x:%02x\n\r", index, > > + addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]); > > setprop(devp, "local-mac-address", addr, 6); > > - > > + } else { > > + printf("ENET%d: no device in tree\n\r", index); > > + } > > index++; > > } > > va_end(ap); > > > > _______________________________________________ > > Linuxppc-dev mailing list > > Linuxppc-dev@ozlabs.org > > https://ozlabs.org/mailman/listinfo/linuxppc-dev > > > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195