From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Grant Likely" <grant.likely@secretlab.ca>,
linuxppc-dev@ozlabs.org, "Scott Wood" <scottwood@freescale.com>
Subject: Re: [PATCH 1/3] bootwrapper: In cuImage, print message for ENET devices not found in tree
Date: Fri, 31 Aug 2007 09:29:03 -0600 [thread overview]
Message-ID: <fa686aa40708310829s344e825dxb1a6d5c3823fa999@mail.gmail.com> (raw)
In-Reply-To: <20070831042536.GL19271@localhost.localdomain>
On 8/30/07, David Gibson <david@gibson.dropbear.id.au> wrote:
> Sorry, I was misleading. Scott moved the printf() into the if (devp)
> as you do, but *didn't* add the alternative warning message in the
> else.
>
> The reason for this is that Planetcore only supplies the first MAC
> address, and the bootwrapper must derive the addresses for all the
> ENETs from that. That in turn means it is much more convenient to
> call fixup_mac_addresses() with more addresses than there are
> ethernets, so we don't want a warning message when that happens.
Okay, that makes sense. I just found Scott's patch which does the
same, so I'll drop my version.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
prev parent reply other threads:[~2007-08-31 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 20:26 [PATCH 1/3] bootwrapper: In cuImage, print message for ENET devices not found in tree Grant Likely
2007-08-30 20:26 ` [PATCH 2/3] mpc8349: Add linux, network-index to ethernet nodes in device tree Grant Likely
2007-08-31 2:44 ` David Gibson
2007-08-30 20:26 ` [PATCH 3/3] mpc8349emitx(gp): update defconfigs for 2.6.23 Grant Likely
2007-08-31 2:43 ` [PATCH 1/3] bootwrapper: In cuImage, print message for ENET devices not found in tree David Gibson
2007-08-31 4:14 ` Grant Likely
2007-08-31 4:25 ` David Gibson
2007-08-31 15:29 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40708310829s344e825dxb1a6d5c3823fa999@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).