From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.181]) by ozlabs.org (Postfix) with ESMTP id 26217DDDE6 for ; Sat, 29 Sep 2007 06:53:11 +1000 (EST) Received: by wa-out-1112.google.com with SMTP id m28so3891855wag for ; Fri, 28 Sep 2007 13:53:11 -0700 (PDT) Message-ID: Date: Fri, 28 Sep 2007 14:52:43 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Olof Johansson" Subject: Re: [PATCH 06/18] [POWERPC] Fix UARTLITE reg io for little-endian architectures (ie. microblaze) In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20070928181421.18608.74224.stgit@trillian.cg.shawcable.net> <20070928181704.18608.40317.stgit@trillian.cg.shawcable.net> <20070928203104.GC23749@lixom.net> <20070928204749.GD23749@lixom.net> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 9/28/07, Grant Likely wrote: > On 9/28/07, Olof Johansson wrote: > > On Fri, Sep 28, 2007 at 02:42:32PM -0600, Grant Likely wrote: > > > On 9/28/07, Olof Johansson wrote: > > > > Also, I'm not sure you need to cast port->membase to void*, do you? The > > > > math will still be right since it's declared as char *. > > > > > > membase is now defined as u32*, so the cast is needed. > > > > Hm, I must have looked at a stale tree. > > No, wait. You're right. It is a char*. I'll drop the cast. Wait, I'm wrong again... it's in/out_be32 that expects an (unsigned*). The compiler complains without the cast. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195