From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.234]) by ozlabs.org (Postfix) with ESMTP id B72B3DDFB1 for ; Wed, 3 Oct 2007 01:56:33 +1000 (EST) Received: by nz-out-0506.google.com with SMTP id i1so2906093nzh for ; Tue, 02 Oct 2007 08:56:29 -0700 (PDT) Message-ID: Date: Tue, 2 Oct 2007 09:56:28 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Peter Korsgaard" Subject: Re: [PATCH 11/18] Virtex: Port UARTLITE driver to of-platform-bus In-Reply-To: <87641p34dn.fsf@macbook.be.48ers.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20070928181421.18608.74224.stgit@trillian.cg.shawcable.net> <20070928181748.18608.62409.stgit@trillian.cg.shawcable.net> <87641p34dn.fsf@macbook.be.48ers.dk> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/2/07, Peter Korsgaard wrote: > >>>>> "Grant" == Grant Likely writes: > Grant> + pr_debug("uartlite: calling platform_driver_register()\n"); > Grant> + if ((ret = platform_driver_register(&ulite_platform_driver)) != 0) > > I prefer to not have assignments in the if (). Already fixed in v3 > Are all the pr_debug necessary? It looks quite messy. Maybe messy, but *very* useful. Looks prettier in the v3 version with the assignment and if() on separate lines. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195