From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179]) by ozlabs.org (Postfix) with ESMTP id BA69DDDFF4 for ; Tue, 9 Oct 2007 07:06:29 +1000 (EST) Received: by wa-out-1112.google.com with SMTP id m28so1891719wag for ; Mon, 08 Oct 2007 14:06:28 -0700 (PDT) Message-ID: Date: Mon, 8 Oct 2007 15:06:27 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Kumar Gala" , "Paul Mackerras" , "Benjamin Herrenschmidt" , "Geoff Levand" Subject: Re: [PATCH] Eval boards should not need to mess with ROOT_DEV In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20071008151254.7777.38512.stgit@trillian.cg.shawcable.net> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/8/07, Grant Likely wrote: > On 10/8/07, Kumar Gala wrote: > > > > On Oct 8, 2007, at 10:12 AM, Grant Likely wrote: > > > > > From: Grant Likely > > > > > > I can't see a good reason for eval board platform code to mess with > > > the > > > ROOT_DEV value instead of using the default behaviour (so I'm writing > > > this patch to see if anyone will clue me in). > > > > > > Signed-off-by: Grant Likely > > > --- > > > > > > arch/powerpc/platforms/52xx/efika.c | 9 --------- > > > arch/powerpc/platforms/52xx/lite5200.c | 12 ------------ > > > arch/powerpc/platforms/82xx/mpc82xx_ads.c | 6 ------ > > > arch/powerpc/platforms/8xx/mpc86xads_setup.c | 2 -- > > > arch/powerpc/platforms/8xx/mpc885ads_setup.c | 2 -- > > > arch/powerpc/platforms/chrp/setup.c | 10 ---------- > > > 6 files changed, 0 insertions(+), 41 deletions(-) > > > > FYI, 82xx_ads and 885ads don't have this issue in my tree based on > > fixes from Scott. > > So, if I respin this patch to exclude those two platforms, will you > merge it? (Efika and Lite5200 only have it because they were cloned > from CHRP. > > Powermac and pseries also do this weirdness. Should it be removed > from there too? Oh, and cell does too. Geoff, does cell support really need to do this: (in cell/setup.c and celleb/setup.c). if (ROOT_DEV == 0) { printk("No ramdisk, default root is /dev/hda2\n"); ROOT_DEV = Root_HDA2; } If not; I'll spin a patch to drop it. Thanks, g. > > g. > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > grant.likely@secretlab.ca > (403) 399-0195 > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195