From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Kumar Gala" <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, arnd@arndb.de
Subject: Re: [PATCH 3/6] Platforms shouldn't mess with ROOT_DEV
Date: Tue, 9 Oct 2007 08:20:11 -0600 [thread overview]
Message-ID: <fa686aa40710090720g5b39550cxa89773b0088fe26@mail.gmail.com> (raw)
In-Reply-To: <E82FBA5B-61A0-4A0A-886B-0FCDD6AFC255@kernel.crashing.org>
On 10/9/07, Kumar Gala <galak@kernel.crashing.org> wrote:
>
> On Oct 8, 2007, at 5:25 PM, Grant Likely wrote:
>
> > From: Grant Likely <grant.likely@secretlab.ca>
> >
> > There is no good reason for board platform code to mess with the
> > ROOT_DEV.
> > Remove it from all in-tree platforms except powermac
> >
> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > ---
> >
> > arch/powerpc/platforms/52xx/efika.c | 9 ---------
> > arch/powerpc/platforms/52xx/lite5200.c | 12 ------------
> > arch/powerpc/platforms/8xx/mpc86xads_setup.c | 2 --
> > arch/powerpc/platforms/cell/setup.c | 5 -----
> > arch/powerpc/platforms/celleb/setup.c | 5 -----
> > arch/powerpc/platforms/chrp/setup.c | 10 ----------
> > arch/powerpc/platforms/pseries/setup.c | 5 -----
> > 7 files changed, 0 insertions(+), 48 deletions(-)
>
> I'd drop mpc86xads_setup since I think Scott's rework will deal with it.
Okay, will do. I wasn't sure since you hadn't explicitly mentioned it.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-10-09 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 22:24 [PATCH 1/6] Only call ppc_md.setup_arch() if it is provided Grant Likely
2007-10-08 22:24 ` [PATCH 2/6] Remove empty ppc_md.setup_arch hooks Grant Likely
2007-10-08 22:25 ` [PATCH 3/6] Platforms shouldn't mess with ROOT_DEV Grant Likely
2007-10-09 13:53 ` Kumar Gala
2007-10-09 14:20 ` Grant Likely [this message]
2007-10-08 22:25 ` [PATCH 4/6] MPC52xx: Drop show_cpuinfo platform hooks from Lite5200 Grant Likely
2007-10-08 22:25 ` [PATCH 5/6] MPC52xx: Trim includes on mpc5200 platform support code Grant Likely
2007-10-09 4:43 ` Stephen Rothwell
2007-10-08 22:25 ` [PATCH 6/6] MPC5200: Don't make firmware fixups into common code Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40710090720g5b39550cxa89773b0088fe26@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=arnd@arndb.de \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).