From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Domen Puncer" <domen.puncer@telargo.com>
Cc: linuxppc-dev@ozlabs.org, jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3 3/4] FEC mpc52xx: the driver
Date: Sun, 14 Oct 2007 15:43:25 -0600 [thread overview]
Message-ID: <fa686aa40710141443u4defd1f4m8076a730a185135b@mail.gmail.com> (raw)
In-Reply-To: <20071014075921.GF3000@nd47.coderock.org>
On 10/14/07, Domen Puncer <domen.puncer@telargo.com> wrote:
> Driver for ethernet on mpc5200/mpc5200b SoCs (FEC).
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
Looks quite good to me. Comments below...
>
> ---
> drivers/net/Kconfig | 1
> drivers/net/Makefile | 1
> drivers/net/fec_mpc52xx/Kconfig | 15
> drivers/net/fec_mpc52xx/Makefile | 2
> drivers/net/fec_mpc52xx/fec.c | 1098 +++++++++++++++++++++++++++++++++++++++
> drivers/net/fec_mpc52xx/fec.h | 313 +++++++++++
> 6 files changed, 1430 insertions(+)
>
> Index: linux.git/drivers/net/Kconfig
> ===================================================================
> --- linux.git.orig/drivers/net/Kconfig
> +++ linux.git/drivers/net/Kconfig
> @@ -1894,6 +1894,7 @@ config NE_H8300
> controller on the Renesas H8/300 processor.
>
> source "drivers/net/fec_8xx/Kconfig"
> +source "drivers/net/fec_mpc52xx/Kconfig"
Personally, I'd just add the mpc52xx items to drivers/net/Kconfig; but
I won't make a fuss either way.
===================================================================
> --- linux.git.orig/drivers/net/Makefile
> +++ linux.git/drivers/net/Makefile
> @@ -210,6 +210,7 @@ obj-$(CONFIG_SMC911X) += smc911x.o
> obj-$(CONFIG_BFIN_MAC) += bfin_mac.o
> obj-$(CONFIG_DM9000) += dm9000.o
> obj-$(CONFIG_FEC_8XX) += fec_8xx/
> +obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx/
Ditto here; Heck, we're only talking about 3 files here. I'd
probably put all three into drivers/net... or even merge the 2 .c and
one .h files into a single file. But, again, it's not a big deal.
> obj-$(CONFIG_PASEMI_MAC) += pasemi_mac.o
> obj-$(CONFIG_MLX4_CORE) += mlx4/
>
> Index: linux.git/drivers/net/fec_mpc52xx/Kconfig
> ===================================================================
> --- /dev/null
> +++ linux.git/drivers/net/fec_mpc52xx/Kconfig
> @@ -0,0 +1,15 @@
> +menu "MPC5200 Networking Options"
> + depends PPC_MPC52xx && NET_ETHERNET
Drop the menu
> +
> +config FEC_MPC52xx
> + tristate "FEC driver"
> + depends on NET_ETHERNET
Drop "NET_ETHERNET"; if you're here, then NET_ETHERNET *is* selected.
Add "PPC_MPC52xx"
> + select PPC_BESTCOMM
> + select PPC_BESTCOMM_FEC
> + select CRC32
> + select PHYLIB
> + ---help---
> + This option enables support for the MPC5200's on-chip
> + Fast Ethernet Controller
> +
> +endmenu
> Index: linux.git/drivers/net/fec_mpc52xx/Makefile
>
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-10-14 21:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 7:55 [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx Domen Puncer
2007-10-14 7:57 ` [PATCH v3 1/4] FEC mpc52xx: device tree changes Domen Puncer
2007-10-14 7:58 ` [PATCH v3 2/4] FEC mpc52xx: add some bestcomm flags Domen Puncer
2007-10-14 7:59 ` [PATCH v3 3/4] FEC mpc52xx: the driver Domen Puncer
2007-10-14 21:43 ` Grant Likely [this message]
2007-10-14 7:59 ` [PATCH v3 4/4] FEC mpc52xx: phy part of " Domen Puncer
2007-10-14 22:05 ` Grant Likely
2007-10-15 10:56 ` [PATCH v3 4/4] FEC mpc52xx: phy part of the driver\ Domen Puncer
2007-10-15 14:30 ` Grant Likely
2007-10-15 19:06 ` [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx Jeff Garzik
2007-10-15 19:19 ` Grant Likely
2007-10-18 14:15 ` Grant Likely
2007-10-18 19:14 ` Jeff Garzik
2007-10-19 11:27 ` [PATCH v4] " Domen Puncer
2007-10-21 18:32 ` Grant Likely
2007-10-25 9:29 ` Jeff Garzik
2007-10-25 14:10 ` Domen Puncer
2007-10-25 18:57 ` Dale Farnsworth
2007-10-25 19:41 ` Domen Puncer
2007-10-25 20:29 ` Dale Farnsworth
2007-10-25 22:46 ` Jeff Garzik
2007-10-25 23:50 ` Stephen Hemminger
2007-10-26 11:59 ` [PATCH v4.2] " Domen Puncer
2007-10-26 14:18 ` Dale Farnsworth
2007-10-26 16:07 ` [PATCH v4.3] " Domen Puncer
2007-10-29 9:59 ` Jeff Garzik
2007-10-29 15:37 ` Grant Likely
2007-11-01 11:31 ` [PATCH v4] " tnt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40710141443u4defd1f4m8076a730a185135b@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=domen.puncer@telargo.com \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).