Re: [PATCH 07/15] [POWERPC] Promess Motion-PRO DTS

["Grant Likely" <grant.likely@secretlab.ca>]

On 10/18/07, Wolfgang Grandegger <wg@grandegger.com> wrote:
> Hello,
>
> I see one more issue.
>
> Marian Balakowicz wrote:
> > Add device tree source file for Motion-PRO board.
> >
> > Signed-off-by: Marian Balakowicz <m8@semihalf.com>
> > ---
> [deletions]
> > +             gpio@b00 {
> > +                     compatible = "mpc5200b-gpio\0mpc5200-gpio";
> > +                     reg = <b00 40>;
> > +                     interrupts = <1 7 0>;
> > +                     interrupt-parent = <&mpc5200_pic>;
> > +             };
>
> Do we not need the field "device_type = "gpio" here?
>
> > +             gpio-wkup@c00 {
> > +                     compatible = "mpc5200b-gpio-wkup\0mpc5200-gpio-wkup";
> > +                     reg = <c00 40>;
> > +                     interrupts = <1 8 0 0 3 0>;
> > +                     interrupt-parent = <&mpc5200_pic>;
> > +             };
>
> And the same here.

'GPIO' is not a standard device type (at least there are no standard
set of GPIO bindings defined) so the device_type field should be
omitted.  Compatible is sufficient.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195