Re: [PATCH v7 5/9] add documentation for SATA nodes

["Grant Likely" <grant.likely@secretlab.ca>]

On 10/19/07, Li Yang <leoli@freescale.com> wrote:
> Signed-off-by: Li Yang <leoli@freescale.com>
> ---
>  Documentation/powerpc/booting-without-of.txt |   32 ++++++++++++++++++++++++++
>  1 files changed, 32 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
> index a96e853..8d49942 100644
> --- a/Documentation/powerpc/booting-without-of.txt
> +++ b/Documentation/powerpc/booting-without-of.txt
> @@ -2242,6 +2242,38 @@ platforms are moved over to use the flattened-device-tree model.
>                            available.
>                            For Axon: 0x0000012a
>
> +    o) SATA nodes
> +
> +    SATA nodes are defined to describe on-chip Serial ATA controllers.
> +
> +    Required properties:
> +
> +    - compatible : Should specify what this SATA controller is compatible
> +      with.
> +    - reg : Offset and length of the register set for the device.
> +    - interrupts : <a b> where a is the interrupt number and b is a
> +      field that represents an encoding of the sense and level
> +      information for the interrupt.  This should be encoded based on
> +      the information in section 2) depending on the type of interrupt
> +      controller you have.
> +    - interrupt-parent : the phandle for the interrupt controller that
> +      services interrupts for this device.
> +
> +    Recommended properties :
> +
> +    - phy-handle : Some SATA controller uses a shared SerDes PHY. This
> +      property should specify the phandle of the SerDes node.

I'm not sure about this property.  Does the driver need to know about
this?  Will this setup ever change at runtime?  It seems to me that
like GPIOs and chip selects, setting you which shared PHY goes with
which device is something that should be done at board setup time.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195