From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Marian Balakowicz" <m8@semihalf.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2 2/4] [POWERPC] Update device tree binding for mpc5200 gpt
Date: Sun, 21 Oct 2007 10:54:33 -0600 [thread overview]
Message-ID: <fa686aa40710210954v3337e82cnf14a487427ecfccc@mail.gmail.com> (raw)
In-Reply-To: <20071018184424.3584.77643.stgit@hekate.izotz.org>
On 10/18/07, Marian Balakowicz <m8@semihalf.com> wrote:
> Add 'fsl,' prefix to 'compatible' property for gpt nodes.
> Add 'fsl,' prefix to empty, GPT0 specific 'has-wdt' property.
Patch doesn't apply; mpc5200_wdt.c watchdog driver is not in the
kernel. I'll pick up the dts change, but you'll need to coordinate w/
Domen to get the needed changes into his driver before it's picked for
mainline.
Cheers,
g.
>
> Signed-off-by: Marian Balakowicz <m8@semihalf.com>
> ---
>
> .../powerpc/mpc52xx-device-tree-bindings.txt | 4 ++-
> arch/powerpc/boot/dts/lite5200.dts | 26 +++++++-------------
> arch/powerpc/boot/dts/lite5200b.dts | 26 +++++++-------------
> drivers/char/watchdog/mpc5200_wdt.c | 3 ++
> 4 files changed, 23 insertions(+), 36 deletions(-)
>
>
> diff --git a/Documentation/powerpc/mpc52xx-device-tree-bindings.txt b/Documentation/powerpc/mpc52xx-device-tree-bindings.txt
> index e59fcbb..fedf7ef 100644
> --- a/Documentation/powerpc/mpc52xx-device-tree-bindings.txt
> +++ b/Documentation/powerpc/mpc52xx-device-tree-bindings.txt
> @@ -185,7 +185,7 @@ bestcomm@<addr> dma-controller mpc5200-bestcomm 5200 pic also requires
> Recommended soc5200 child nodes; populate as needed for your board
> name device_type compatible Description
> ---- ----------- ---------- -----------
> -gpt@<addr> gpt mpc5200-gpt General purpose timers
> +gpt@<addr> gpt fsl,mpc5200-gpt General purpose timers
> rtc@<addr> rtc mpc5200-rtc Real time clock
> mscan@<addr> mscan mpc5200-mscan CAN bus controller
> pci@<addr> pci mpc5200-pci PCI bridge
> @@ -213,7 +213,7 @@ cell-index int When multiple devices are present, is the
> 5) General Purpose Timer nodes (child of soc5200 node)
> On the mpc5200 and 5200b, GPT0 has a watchdog timer function. If the board
> design supports the internal wdt, then the device node for GPT0 should
> -include the empty property 'has-wdt'.
> +include the empty property 'fsl,has-wdt'.
>
> 6) PSC nodes (child of soc5200 node)
> PSC nodes can define the optional 'port-number' property to force assignment
> diff --git a/arch/powerpc/boot/dts/lite5200.dts b/arch/powerpc/boot/dts/lite5200.dts
> index bc45f5f..6731763 100644
> --- a/arch/powerpc/boot/dts/lite5200.dts
> +++ b/arch/powerpc/boot/dts/lite5200.dts
> @@ -70,18 +70,16 @@
> };
>
> gpt@600 { // General Purpose Timer
> - compatible = "mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200-gpt";
> cell-index = <0>;
> reg = <600 10>;
> interrupts = <1 9 0>;
> interrupt-parent = <&mpc5200_pic>;
> - has-wdt;
> + fsl,has-wdt;
> };
>
> gpt@610 { // General Purpose Timer
> - compatible = "mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200-gpt";
> cell-index = <1>;
> reg = <610 10>;
> interrupts = <1 a 0>;
> @@ -89,8 +87,7 @@
> };
>
> gpt@620 { // General Purpose Timer
> - compatible = "mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200-gpt";
> cell-index = <2>;
> reg = <620 10>;
> interrupts = <1 b 0>;
> @@ -98,8 +95,7 @@
> };
>
> gpt@630 { // General Purpose Timer
> - compatible = "mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200-gpt";
> cell-index = <3>;
> reg = <630 10>;
> interrupts = <1 c 0>;
> @@ -107,8 +103,7 @@
> };
>
> gpt@640 { // General Purpose Timer
> - compatible = "mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200-gpt";
> cell-index = <4>;
> reg = <640 10>;
> interrupts = <1 d 0>;
> @@ -116,8 +111,7 @@
> };
>
> gpt@650 { // General Purpose Timer
> - compatible = "mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200-gpt";
> cell-index = <5>;
> reg = <650 10>;
> interrupts = <1 e 0>;
> @@ -125,8 +119,7 @@
> };
>
> gpt@660 { // General Purpose Timer
> - compatible = "mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200-gpt";
> cell-index = <6>;
> reg = <660 10>;
> interrupts = <1 f 0>;
> @@ -134,8 +127,7 @@
> };
>
> gpt@670 { // General Purpose Timer
> - compatible = "mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200-gpt";
> cell-index = <7>;
> reg = <670 10>;
> interrupts = <1 10 0>;
> diff --git a/arch/powerpc/boot/dts/lite5200b.dts b/arch/powerpc/boot/dts/lite5200b.dts
> index 6582c9a..b540388 100644
> --- a/arch/powerpc/boot/dts/lite5200b.dts
> +++ b/arch/powerpc/boot/dts/lite5200b.dts
> @@ -70,18 +70,16 @@
> };
>
> gpt@600 { // General Purpose Timer
> - compatible = "mpc5200b-gpt","mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> cell-index = <0>;
> reg = <600 10>;
> interrupts = <1 9 0>;
> interrupt-parent = <&mpc5200_pic>;
> - has-wdt;
> + fsl,has-wdt;
> };
>
> gpt@610 { // General Purpose Timer
> - compatible = "mpc5200b-gpt","mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> cell-index = <1>;
> reg = <610 10>;
> interrupts = <1 a 0>;
> @@ -89,8 +87,7 @@
> };
>
> gpt@620 { // General Purpose Timer
> - compatible = "mpc5200b-gpt","mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> cell-index = <2>;
> reg = <620 10>;
> interrupts = <1 b 0>;
> @@ -98,8 +95,7 @@
> };
>
> gpt@630 { // General Purpose Timer
> - compatible = "mpc5200b-gpt","mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> cell-index = <3>;
> reg = <630 10>;
> interrupts = <1 c 0>;
> @@ -107,8 +103,7 @@
> };
>
> gpt@640 { // General Purpose Timer
> - compatible = "mpc5200b-gpt","mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> cell-index = <4>;
> reg = <640 10>;
> interrupts = <1 d 0>;
> @@ -116,8 +111,7 @@
> };
>
> gpt@650 { // General Purpose Timer
> - compatible = "mpc5200b-gpt","mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> cell-index = <5>;
> reg = <650 10>;
> interrupts = <1 e 0>;
> @@ -125,8 +119,7 @@
> };
>
> gpt@660 { // General Purpose Timer
> - compatible = "mpc5200b-gpt","mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> cell-index = <6>;
> reg = <660 10>;
> interrupts = <1 f 0>;
> @@ -134,8 +127,7 @@
> };
>
> gpt@670 { // General Purpose Timer
> - compatible = "mpc5200b-gpt","mpc5200-gpt";
> - device_type = "gpt";
> + compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> cell-index = <7>;
> reg = <670 10>;
> interrupts = <1 10 0>;
> diff --git a/drivers/char/watchdog/mpc5200_wdt.c b/drivers/char/watchdog/mpc5200_wdt.c
> index 9cfb975..11f6a11 100644
> --- a/drivers/char/watchdog/mpc5200_wdt.c
> +++ b/drivers/char/watchdog/mpc5200_wdt.c
> @@ -176,6 +176,8 @@ static int mpc5200_wdt_probe(struct of_device *op, const struct of_device_id *ma
>
> has_wdt = of_get_property(op->node, "has-wdt", NULL);
> if (!has_wdt)
> + has_wdt = of_get_property(op->node, "fsl,has-wdt", NULL);
> + if (!has_wdt)
> return -ENODEV;
>
> wdt = kzalloc(sizeof(*wdt), GFP_KERNEL);
> @@ -254,6 +256,7 @@ static int mpc5200_wdt_shutdown(struct of_device *op)
>
> static struct of_device_id mpc5200_wdt_match[] = {
> { .compatible = "mpc5200-gpt", },
> + { .compatible = "fsl,mpc5200-gpt", },
> {},
> };
> static struct of_platform_driver mpc5200_wdt_driver = {
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-10-21 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 18:44 [PATCH v2 0/4] [POWERPC] MPC5200: update gpt binding, add restart support Marian Balakowicz
2007-10-18 18:44 ` [PATCH v2 1/4] [POWERPC] Add mpc52xx_find_and_map_path(), refactor utility functions Marian Balakowicz
2007-10-18 18:44 ` [PATCH v2 2/4] [POWERPC] Update device tree binding for mpc5200 gpt Marian Balakowicz
2007-10-21 16:54 ` Grant Likely [this message]
2007-10-21 17:25 ` Grant Likely
2007-10-18 18:44 ` [PATCH v2 3/4] [POWERPC] Add restart support for mpc52xx based platforms Marian Balakowicz
2007-10-18 18:53 ` Grant Likely
2007-10-18 19:03 ` Marian Balakowicz
2007-10-18 18:44 ` [PATCH v2 4/4] [POWERPC] Enable restart support for lite5200 board Marian Balakowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40710210954v3337e82cnf14a487427ecfccc@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=m8@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).