From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.234]) by ozlabs.org (Postfix) with ESMTP id 417DCDDEB7 for ; Thu, 25 Oct 2007 00:09:20 +1000 (EST) Received: by nz-out-0506.google.com with SMTP id i1so192285nzh for ; Wed, 24 Oct 2007 07:09:19 -0700 (PDT) Message-ID: Date: Wed, 24 Oct 2007 08:09:17 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Marian Balakowicz" , linuxppc-dev@ozlabs.org Subject: Re: [PATCH 05/11] [POWERPC] TQM5200 DTS In-Reply-To: <20071024015115.GK10595@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20071023231302.29359.27417.stgit@hekate.izotz.org> <20071023231333.29359.35252.stgit@hekate.izotz.org> <20071024015115.GK10595@localhost.localdomain> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/23/07, David Gibson wrote: > On Wed, Oct 24, 2007 at 01:13:33AM +0200, Marian Balakowicz wrote: > > Add device tree source file for TQM5200 board. > > > > Signed-off-by: Marian Balakowicz > > --- > > > > arch/powerpc/boot/dts/tqm5200.dts | 236 +++++++++++++++++++++++++++++++++++++ > > 1 files changed, 236 insertions(+), 0 deletions(-) > > create mode 100644 arch/powerpc/boot/dts/tqm5200.dts > > > > > > diff --git a/arch/powerpc/boot/dts/tqm5200.dts b/arch/powerpc/boot/dts/tqm5200.dts > > new file mode 100644 > > index 0000000..01c7778 > > --- /dev/null > > +++ b/arch/powerpc/boot/dts/tqm5200.dts > > @@ -0,0 +1,236 @@ > > +/* > > + * TQM5200 board Device Tree Source > [snip] > > + soc5200@f0000000 { > > I thought we were moving towards calling these just /soc@address? The only reason this is still like this is that u-boot does a path based lookup for the soc5200 node on the TQM board. We need to change u-boot too before the 5200 can be dropped. > > > + model = "fsl,mpc5200"; > > + compatible = "mpc5200"; > > That should have a vendor prefix. > > [snip] > > + serial@2000 { // PSC1 > > + device_type = "serial"; > > + compatible = "mpc5200-psc-uart"; > > + port-number = <0>; // Logical port assignment > > How are these port-number things used? The device tree shouldn't > generally contain information that isn't inherent to the hardware. > There can be reasons for hacks like this, but we should avoid them if > possible. This was an approach I was taking a while back to assign logical ports (ttyPSC0) to a PSC. I'm working on eliminating this. As you suggested, I'm looking into using aliases for this. > > > + cell-index = <0>; > > cell-index should only be used if the index number is used when > manipulating the hardware (e.g. if there's a global control register > which takes this number). And there is in this case. > > [snip] > > + ata@3a00 { > > + device_type = "ata"; > > No such thing as device_type = "ata", drop it. In general, never > include a device_type unless a binding explicitly says to do so. Again, my fault from the lite5200. > > [snip] > > + lpb@fc000000 { > > + model = "fsl,lpb"; > > + compatible = "lpb"; > > Not nearly specific enough. Must include a vendor prefix at least, > and should have a lot more revision information. You should always be > able to pick the right driver with compatible alone, "model" should > generally be for human consumption, the driver shouldn't need it. > > > + device_type = "lpb"; > > Drop this. Again, presence of a device_type property is the > exception, not the rule. > > > + ranges = <0 fc000000 02000000>; > > You need #address-cells and #size-cells properties, too. > > [snip] > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195