From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: Date: Wed, 24 Oct 2007 09:20:44 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Jon Smirl" Subject: Re: Audio codec device tree entries In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <9e4733910710221859q6ea54810nba58907d5ddd966d@mail.gmail.com> <471E12C7.8020509@freescale.com> <8416ea754e013a67441aec778c81ad73@kernel.crashing.org> <9e4733910710231529h1089eacdy888306f20af92555@mail.gmail.com> <471F52ED.10007@freescale.com> <9e4733910710240800y24952e70g8c318e35e2e45e2e@mail.gmail.com> Cc: PowerPC dev list , Timur Tabi List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/24/07, Grant Likely wrote: > On 10/24/07, Jon Smirl wrote: > > On 10/24/07, Timur Tabi wrote: > > > Jon Smirl wrote: > > > > Is this consensus on how the tree should look? > > > > > > > > There is no attempt to describe the codec connections inside the > > > > device tree. > > > > > > I don't think I agree with that. The device tree should indicate which codec is > > > connected to which I2S/AC97 device. > > > > What I meant was that there is no attempt to describe how the codec is > > connected to the external world. Those connections are described in > > the fabric driver. > > > > I'm getting conflicting opinions on how the devices should be linked > > into the tree. We should pick one and add it to the documentation. > > Two valid methods have been proposed > 1. a codec- oops 1. a codec-handle property in the i2s node 2. an i2s-handle property in the codec node Either are reasonable. I prefer putting the handle in the i2s node; but I'm looking at it from the way that ethernet phys are being described currently. The other is also perfectly valid. I suppose it depends on what point of view you see the system from; either: a. the codec is supported by the i2s bus, in which case use the i2s-handle property b. the i2s bus is supported by the codec; in which case use the codec-handle property. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195