From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: Date: Wed, 24 Oct 2007 10:39:44 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Timur Tabi" Subject: Re: Audio codec device tree entries In-Reply-To: <471F6C3F.10003@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <9e4733910710221859q6ea54810nba58907d5ddd966d@mail.gmail.com> <9e4733910710231529h1089eacdy888306f20af92555@mail.gmail.com> <471F52ED.10007@freescale.com> <9e4733910710240800y24952e70g8c318e35e2e45e2e@mail.gmail.com> <9e4733910710240828x412f598dy7fc4a75faa76358d@mail.gmail.com> <9e4733910710240854y6ac115b6i5e0400eb369fcf7@mail.gmail.com> <471F6C3F.10003@freescale.com> Cc: PowerPC dev list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/24/07, Timur Tabi wrote: > Jon Smirl wrote: > > > It makes sense to me, there needs to be some way to trigger loading > > the fabric driver. > > Well, you only really two have choices: > > 1) Probe on the AC97/SSI nodes > 2) When the driver initializes, just scan all the nodes in the device tree (no > probing). > > I think option #2 makes the most sense, because option #1 says that your fabric > driver is really an AC97 driver, which it isn't. If you need to scan the tree, don't do it when the driver registers, do it in the platform code instead. Otherwise you unconditionally incur the penalty of scanning the whole device tree on every system that loads the driver, regardless of whether or not the device is present. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195