mpc5200, sysctl table check failed

mpc5200, sysctl table check failed

[Jon Smirl]

I'm porting mpc5200 support for the Phytec pcm030 onto current git
head. When booting I get this:

sysctl table check failed: /kernel .1 Writable sysctl directory
Call Trace:
[c0817ee0] [c0008034] show_stack+0x50/0x184 (unreliable)
[c0817f00] [c003cfc8] set_fail+0x50/0x68
[c0817f20] [c003d630] sysctl_check_table+0x650/0x6a0
[c0817f50] [c002a9b8] register_sysctl_table+0x64/0xb4
[c0817f70] [c02dee70] register_powersave_nap_sysctl+0x18/0x2c
[c0817f80] [c02d81d0] kernel_init+0xb4/0x270
[c0817ff0] [c0011be0] kernel_thread+0x44/0x60

What's going on? I get all the way through boot and user space doesn't
start, this is probably why.


-- 
Jon Smirl
jonsmirl@gmail.com

Re: mpc5200, sysctl table check failed

[Grant Likely]

On 11/7/07, Jon Smirl <jonsmirl@gmail.com> wrote:
> I'm porting mpc5200 support for the Phytec pcm030 onto current git
> head. When booting I get this:
>
> sysctl table check failed: /kernel .1 Writable sysctl directory
> Call Trace:
> [c0817ee0] [c0008034] show_stack+0x50/0x184 (unreliable)
> [c0817f00] [c003cfc8] set_fail+0x50/0x68
> [c0817f20] [c003d630] sysctl_check_table+0x650/0x6a0
> [c0817f50] [c002a9b8] register_sysctl_table+0x64/0xb4
> [c0817f70] [c02dee70] register_powersave_nap_sysctl+0x18/0x2c
> [c0817f80] [c02d81d0] kernel_init+0xb4/0x270
> [c0817ff0] [c0011be0] kernel_thread+0x44/0x60
>
> What's going on? I get all the way through boot and user space doesn't
> start, this is probably why.

I see the same thing on the latest git (or at least latest as of last
night); except for me I have no problem with userspace starting.  This
is on a Xilinx Virtex 405.

Cheers,
g.

>
>
> --
> Jon Smirl
> jonsmirl@gmail.com
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

Re: mpc5200, sysctl table check failed

[Jon Smirl]

On 11/7/07, Grant Likely <grant.likely@secretlab.ca> wrote:
> On 11/7/07, Jon Smirl <jonsmirl@gmail.com> wrote:
> > I'm porting mpc5200 support for the Phytec pcm030 onto current git
> > head. When booting I get this:
> >
> > sysctl table check failed: /kernel .1 Writable sysctl directory
> > Call Trace:
> > [c0817ee0] [c0008034] show_stack+0x50/0x184 (unreliable)
> > [c0817f00] [c003cfc8] set_fail+0x50/0x68
> > [c0817f20] [c003d630] sysctl_check_table+0x650/0x6a0
> > [c0817f50] [c002a9b8] register_sysctl_table+0x64/0xb4
> > [c0817f70] [c02dee70] register_powersave_nap_sysctl+0x18/0x2c
> > [c0817f80] [c02d81d0] kernel_init+0xb4/0x270
> > [c0817ff0] [c0011be0] kernel_thread+0x44/0x60
> >
> > What's going on? I get all the way through boot and user space doesn't
> > start, this is probably why.
>
> I see the same thing on the latest git (or at least latest as of last
> night); except for me I have no problem with userspace starting.  This
> is on a Xilinx Virtex 405.

Olof's patch fixes it.
http://patchwork.ozlabs.org/linuxppc/patch?id=14612

Phytec pcm030.c depended on mpc52xx_setup_cpu which got removed. I
fixed it up by copying the old version into pcm030.c. There must be
more to the fix.

/*
 * Phytec mpc5200b tiny (pcm030) board support
 *
 * Written by: Sascha Hauer <s.hauer@pengutronix.de>
 *
 * Copyright (C) 2006 Pengutronix
 *
 * Description:
 * This program is free software; you can redistribute  it and/or modify it
 * under  the terms of  the GNU General  Public License as published by the
 * Free Software Foundation;  either version 2 of the  License, or (at your
 * option) any later version.
 */

#include <linux/stddef.h>
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/errno.h>
#include <linux/reboot.h>
#include <linux/pci.h>
#include <linux/kdev_t.h>
#include <linux/major.h>
#include <linux/console.h>
#include <linux/delay.h>
#include <linux/seq_file.h>
#include <linux/root_dev.h>
#include <linux/initrd.h>

#include <asm/system.h>
#include <asm/atomic.h>
#include <asm/time.h>
#include <asm/io.h>
#include <asm/machdep.h>
#include <asm/ipic.h>
#include <asm/mpc52xx.h>
#include <asm/irq.h>
#include <asm/prom.h>
#include <asm/udbg.h>
#include <sysdev/fsl_soc.h>
#include <asm/qe.h>
#include <asm/qe_ic.h>
#include <asm/of_platform.h>
#include <linux/mtd/physmap.h>
#include <linux/platform_device.h>
#include <linux/fsl_devices.h>

#include <asm/mpc52xx.h>

static struct __iomem mpc52xx_gpt *gpt = NULL;

static void __init
mpc52xx_setup_cpu(void)
{
	struct mpc52xx_cdm  __iomem *cdm;
	struct mpc52xx_xlb  __iomem *xlb;

	/* needed for mpc52xx_restart */
	gpt = mpc52xx_find_and_map("mpc52xx-gpt");

	/* Map zones */
	cdm = mpc52xx_find_and_map("mpc5200-cdm");
	xlb = mpc52xx_find_and_map("mpc5200-xlb");

	if (!cdm || !xlb) {
		printk(KERN_ERR __FILE__ ": "
			"Error while mapping CDM/XLB during mpc52xx_setup_cpu. "
			"Expect some abnormal behavior\n");
		goto unmap_regs;
	}

	/* Use internal 48 Mhz */
	out_8(&cdm->ext_48mhz_en, 0x00);
	out_8(&cdm->fd_enable, 0x01);
	if (in_be32(&cdm->rstcfg) & 0x40)	/* Assumes 33Mhz clock */
		out_be16(&cdm->fd_counters, 0x0001);
	else
		out_be16(&cdm->fd_counters, 0x5555);

	/* Configure the XLB Arbiter priorities */
	out_be32(&xlb->master_pri_enable, 0xff);
	out_be32(&xlb->master_priority, 0x11111111);

	/* Disable XLB pipelining */
	/* (cfr errate 292. We could do this only just before ATA PIO
	    transaction and re-enable it afterwards ...) */
	out_be32(&xlb->config, in_be32(&xlb->config) | MPC52xx_XLB_CFG_PLDIS);

	/* Unmap zones */
unmap_regs:
	if (cdm) iounmap(cdm);
	if (xlb) iounmap(xlb);
}

struct mpc52xx_gpio __iomem *mpc52xx_gpio=NULL;
struct mpc52xx_gpio_wkup __iomem *mpc52xx_wkpio=NULL;
EXPORT_SYMBOL(mpc52xx_gpio);
EXPORT_SYMBOL(mpc52xx_wkpio);

/*
 * Map the GPIO relevant register fix and global.
 * They will be used in the Pengutronix' GOIO framework
 * This is very PCM030 specific stuff!
 */
static void __init pcm030_gpio_setup(void)
{
	mpc52xx_gpio = mpc52xx_find_and_map("mpc52xx-gpio");
	if (mpc52xx_gpio == NULL) {
		printk(KERN_ERR "%s: Error while mapping GPIO register for port config. "
				"Expect some abnormal behavior\n",__FILE__);
		goto error;
	}

	mpc52xx_wkpio = mpc52xx_find_and_map("mpc52xx-gpio-wkup");
	if (mpc52xx_wkpio == NULL) {
		printk(KERN_ERR "%s: "
				"Error while mapping WAKEUP register for port config. "
				"Expect some abnormal behavior\n",__FILE__);
		goto error;
	}

	return;

error:
	if (mpc52xx_gpio != NULL)
		iounmap(mpc52xx_gpio);
	if (mpc52xx_wkpio != NULL)
		iounmap(mpc52xx_wkpio);
}

static void __init pcm030_setup_arch(void)
{
	struct device_node *np;

	if (ppc_md.progress)
		ppc_md.progress("pcm030_setup_arch()", 0);

	np = of_find_node_by_type(NULL, "cpu");
	if (np) {
		unsigned int *fp =
		    (int *)of_get_property(np, "clock-frequency", NULL);
		if (fp != 0)
			loops_per_jiffy = *fp / HZ;
		else
			loops_per_jiffy = 50000000 / HZ;
		of_node_put(np);
	}

	mpc52xx_setup_cpu();
	pcm030_gpio_setup();
}

static struct physmap_flash_data pcm030_flash_data = {
	.width	= 1,
};

static struct resource pcm030_flash_resource = {
	.start		= 0xff000000,
	.end		= 0xffffffff,
	.flags		= IORESOURCE_MEM,
};

static struct platform_device pcm030_flash = {
	.name		= "physmap-flash",
	.id		= 0,
	.dev		= {
				.platform_data	= &pcm030_flash_data,
			},
	.resource	= &pcm030_flash_resource,
	.num_resources	= 1,
};

#define MBAR_BASE 0xf0000000

static int __init pcm030_register_flash(void)
{
	void __iomem *mbar;
	unsigned int cs0;

	/*
	 * The pcm030 comes with different flash buswidths. Detect
	 * it by looking in the chipselect setup register
	 */
	mbar = ioremap(MBAR_BASE, 0x1000);
	if (!mbar)
		return -EINVAL;

	cs0 = in_be32(mbar + 0x300);

	iounmap(mbar);

	switch ((cs0 >> 8) & 0x3) {
	case 0:
		pcm030_flash_data.width = 1;
		break;
	case 1:
		pcm030_flash_data.width = 2;
		break;
	case 3:
		pcm030_flash_data.width = 4;
		break;
	}

	return platform_device_register(&pcm030_flash);
}

static void __init pcm030_init(void)
{
	pcm030_register_flash();
	mpc52xx_declare_of_platform_devices();
}

void pcm030_show_cpuinfo(struct seq_file *m)
{
	seq_printf(m, "vendor\t\t:	Phytec\n");
	seq_printf(m, "machine\t\t:	Phycore mpc5200b tiny (pcm030)\n");
}

/*
 * Called very early, MMU is off, device-tree isn't unflattened
 */
static int __init pcm030_probe(void)
{
	unsigned long node = of_get_flat_dt_root();

	if (!of_flat_dt_is_compatible(node, "fsl,pcm030"))
		return 0;

	return 1;
}

define_machine(pcm030) {
	.name 		= "pcm030",
	.probe 		= pcm030_probe,
	.setup_arch 	= pcm030_setup_arch,
	.restart	= mpc52xx_restart,
	.init           = pcm030_init,
	.init_IRQ 	= mpc52xx_init_irq,
	.get_irq 	= mpc52xx_get_irq,
	.show_cpuinfo	= pcm030_show_cpuinfo,
	.calibrate_decr	= generic_calibrate_decr,
};


-- 
Jon Smirl
jonsmirl@gmail.com

Re: mpc5200, sysctl table check failed

[Olof Johansson]

On Wed, Nov 07, 2007 at 03:24:12PM -0500, Jon Smirl wrote:
> I'm porting mpc5200 support for the Phytec pcm030 onto current git
> head. When booting I get this:
> 
> sysctl table check failed: /kernel .1 Writable sysctl directory
> Call Trace:
> [c0817ee0] [c0008034] show_stack+0x50/0x184 (unreliable)
> [c0817f00] [c003cfc8] set_fail+0x50/0x68
> [c0817f20] [c003d630] sysctl_check_table+0x650/0x6a0
> [c0817f50] [c002a9b8] register_sysctl_table+0x64/0xb4
> [c0817f70] [c02dee70] register_powersave_nap_sysctl+0x18/0x2c
> [c0817f80] [c02d81d0] kernel_init+0xb4/0x270
> [c0817ff0] [c0011be0] kernel_thread+0x44/0x60
> 
> What's going on? I get all the way through boot and user space doesn't
> start, this is probably why.

Hi,

I posted a patch for this yesterday, it's harmless, just a warning.


http://patchwork.ozlabs.org/linuxppc/patch?id=14612

-Olof

Re: mpc5200, sysctl table check failed

[Grant Likely]

On 11/7/07, Jon Smirl <jonsmirl@gmail.com> wrote:
> On 11/7/07, Grant Likely <grant.likely@secretlab.ca> wrote:
> > On 11/7/07, Jon Smirl <jonsmirl@gmail.com> wrote:
> > > I'm porting mpc5200 support for the Phytec pcm030 onto current git
> > > head. When booting I get this:
> > >
> > > sysctl table check failed: /kernel .1 Writable sysctl directory
> > > Call Trace:
> > > [c0817ee0] [c0008034] show_stack+0x50/0x184 (unreliable)
> > > [c0817f00] [c003cfc8] set_fail+0x50/0x68
> > > [c0817f20] [c003d630] sysctl_check_table+0x650/0x6a0
> > > [c0817f50] [c002a9b8] register_sysctl_table+0x64/0xb4
> > > [c0817f70] [c02dee70] register_powersave_nap_sysctl+0x18/0x2c
> > > [c0817f80] [c02d81d0] kernel_init+0xb4/0x270
> > > [c0817ff0] [c0011be0] kernel_thread+0x44/0x60
> > >
> > > What's going on? I get all the way through boot and user space doesn't
> > > start, this is probably why.
> >
> > I see the same thing on the latest git (or at least latest as of last
> > night); except for me I have no problem with userspace starting.  This
> > is on a Xilinx Virtex 405.
>
> Olof's patch fixes it.
> http://patchwork.ozlabs.org/linuxppc/patch?id=14612
>
> Phytec pcm030.c depended on mpc52xx_setup_cpu which got removed. I
> fixed it up by copying the old version into pcm030.c. There must be
> more to the fix.

Do "git log arch/powerpc/platforms/52xx" to see the when it got
removed and why.  You should match that change in your pcm030.c.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

Re: mpc5200, sysctl table check failed

[Jon Smirl]

On 11/7/07, Grant Likely <grant.likely@secretlab.ca> wrote:
> > Phytec pcm030.c depended on mpc52xx_setup_cpu which got removed. I
> > fixed it up by copying the old version into pcm030.c. There must be
> > more to the fix.
>
> Do "git log arch/powerpc/platforms/52xx" to see the when it got
> removed and why.  You should match that change in your pcm030.c.

Looking at it some more it may be the FEC that is stopping user space
from loading. DHCP gets an address but nfs can't mount my root
partition. The nfs server is working since I can mount it from another
machine. Of course user space won't start if nfs can't read the files.

I clipped out non-net related entries.

DMA: MPC52xx BestComm driver
DMA: MPC52xx BestComm engine @f0001200 ok !
SCSI subsystem initialized
NET: Registered protocol family 2
IP route cache hash table entries: 1024 (order: 0, 4096 bytes)
TCP established hash table entries: 2048 (order: 2, 16384 bytes)
TCP bind hash table entries: 2048 (order: 1, 8192 bytes)
TCP: Hash tables configured (established 2048 bind 2048)
TCP reno registered
audit: initializing netlink socket (disabled)
audit(0.230:1): initialized
mpc52xx MII bus: probed
TCP cubic registered
NET: Registered protocol family 1
NET: Registered protocol family 17
RPC: Registered udp transport module.
RPC: Registered tcp transport module.
net eth0: attached phy 0 to driver Generic PHY
Sending DHCP requests .<6>PHY: f0003000:00 - Link is Up - 100/Full
., OK
IP-Config: Got DHCP answer from 192.168.1.200, my address is 192.168.1.5
IP-Config: Complete:
      device=eth0, addr=192.168.1.5, mask=255.255.255.0, gw=192.168.1.200,
     host=MPC, domain=home, nis-domain=(none),
     bootserver=192.168.1.200, rootserver=192.168.1.4, rootpath=
Looking up port of RPC 100003/3 on 192.168.1.4
Looking up port of RPC 100005/3 on 192.168.1.4
VFS: Mounted root (nfs filesystem).
Freeing unused kernel memory: 172k init
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying

-- 
Jon Smirl
jonsmirl@gmail.com

Re: mpc5200, sysctl table check failed

[Jon Smirl]

While is was doing "nfs: server 192.168.1.4 not responding, still
trying" it Oops'd.

Oops: Kernel access of bad area, sig: 11 [#1]
pcm030
Modules linked in:
NIP: c01f77a8 LR: c01f778c CTR: 00000000
REGS: c0327c00 TRAP: 0300   Not tainted  (2.6.24-rc2-efika-gf96ef878)
MSR: 00009032 <EE,ME,IR,DR>  CR: 28000044  XER: 00000000
DAR: 005f600f, DSISR: 20000000
TASK = c0305570[0] 'swapper' THREAD: c0326000
GPR00: 7175655f c0327cb0 c0305570 00000119 000099b1 c0952000 00000000 000002e4
GPR08: 00000006 00000001 c0a80105 c034fb9c 330fa340 ffefffff 03ffe000 ffffffff
GPR16: 00000001 00000000 007ffc00 00000000 00000000 03ff8838 00000000 c0327d50
GPR24: 000002d0 000005a8 c0330e7c c0921184 c0327d60 00000464 c0327d50 005f5f77
NIP [c01f77a8] __ip_route_output_key+0x54/0x8f4
LR [c01f778c] __ip_route_output_key+0x38/0x8f4
Call Trace:
[c0327cb0] [c01f802c] __ip_route_output_key+0x8d8/0x8f4 (unreliable)
[c0327d30] [c01f8064] ip_route_output_flow+0x1c/0x74
[c0327d40] [c0221864] inet_sk_rebuild_header+0xb8/0x2c0
[c0327e10] [c0210558] tcp_retransmit_skb+0x478/0x654
[c0327e40] [c0212efc] tcp_write_timer+0x450/0x670
[c0327e60] [c002c5f4] run_timer_softirq+0x12c/0x1b4
[c0327e90] [c00284d0] __do_softirq+0x64/0xd4
[c0327eb0] [c0006144] do_softirq+0x40/0x58
[c0327ec0] [c002837c] irq_exit+0x38/0x48
[c0327ed0] [c000f758] timer_interrupt+0x164/0x180
[c0327ee0] [c0012444] ret_from_except+0x0/0x14
--- Exception: 901 at cpu_idle+0x88/0xd0
    LR = cpu_idle+0x88/0xd0
[c0327fa0] [c0009038] cpu_idle+0xcc/0xd0 (unreliable)
[c0327fb0] [c024fa34] rest_init+0x50/0x60
[c0327fc0] [c02d89c4] start_kernel+0x298/0x2ac
[c0327ff0] [00003438] 0x3438
Instruction dump:
54842834 7c042278 4bffe91d 7c7d1b78 4be30dcd 3d20c033 8129e9d8 57bd103a
7ffd482e 3d20c035 3969fb9c 48000074 <801f0098> 813c000c 7f804800 40be0054
Kernel panic - not syncing: Fatal exception in interrupt
Rebooting in 180 seconds..





-- 
Jon Smirl
jonsmirl@gmail.com

Re: mpc5200, sysctl table check failed

[Jon Smirl]

I think whatever is broken in my FEC code is exposing a different bug
in some timeout code that is not normally run. Something to do with
the swap thread being unable to get to the swap device maybe?

Can anyone tell me where this Oops is coming from? It is the same oops
as the previous one, but the stacks are different.

I am getting it after a random number of retries of:
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying
nfs: server 192.168.1.4 not responding, still trying

Using current git head.

Unable to handle kernel paging request for data at address 0x0000001b
Faulting instruction address: 0xc0027288
Oops: Kernel access of bad area, sig: 11 [#1]
pcm030
Modules linked in:
NIP: c0027288 LR: c0027284 CTR: c00274c4
REGS: c031bd80 TRAP: 0300   Not tainted  (2.6.24-rc2-efika-g34082a7d-dirty)
MSR: 00001032 <ME,IR,DR>  CR: 28000028  XER: 00000000
DAR: 0000001b, DSISR: 20000000
TASK = c02fa570[0] 'swapper' THREAD: c031a000
GPR00: 03ffffff c031be30 c02fa570 c032e9a8 0000001b 00000001 c0320000 c0320000
GPR08: c02febd8 c032e9a8 00004000 00000000 248e3746 ffefffff 03ffe000 ffffffff
GPR16: 00000001 00000000 007ffc00 00000000 00000000 03ff8838 00000000 00000004
GPR24: 00000000 00000000 c032341c c0320000 c031a000 00000001 c032e9a0 0000001b
NIP [c0027288] cascade+0x74/0x9c
LR [c0027284] cascade+0x70/0x9c
Call Trace:
[c031be30] [c0018c94] __update_rq_clock+0x20/0x124 (unreliable)
[c031be60] [c002753c] run_timer_softirq+0x78/0x1b4
[c031be90] [c00234cc] __do_softirq+0x64/0xd4
[c031beb0] [c0006144] do_softirq+0x40/0x58
[c031bec0] [c0023378] irq_exit+0x38/0x48
[c031bed0] [c000d178] timer_interrupt+0x164/0x180
[c031bee0] [c000fe64] ret_from_except+0x0/0x14
--- Exception: 901 at cpu_idle+0x88/0xd0
    LR = cpu_idle+0x88/0xd0
[c031bfa0] [c0009038] cpu_idle+0xcc/0xd0 (unreliable)
[c031bfb0] [c024aa30] rest_init+0x50/0x60
[c031bfc0] [c02d19c4] start_kernel+0x298/0x2ac
[c031bff0] [00003438] 0x3438
Instruction dump:
80810008 83e40000 4800002c 80040014 5400003c 7c00f278 3160ffff 7d2b0110
0f090000 7fc3f378 4bfffecd 7fe4fb78 <83ff0000> 38010008 7f840000 409effd0
Kernel panic - not syncing: Fatal exception in interrupt
Rebooting in 180 seconds..


-- 
Jon Smirl
jonsmirl@gmail.com

Re: mpc5200, sysctl table check failed

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]



> I posted a patch for this yesterday, it's harmless, just a warning.

That's not actually true, if the sysctl check code warns in any way the
sysctl file doesn't show up in /proc/sys/

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: mpc5200, sysctl table check failed

[Olof Johansson]

On Thu, Nov 08, 2007 at 04:09:39PM +0100, Johannes Berg wrote:
> 
> 
> > I posted a patch for this yesterday, it's harmless, just a warning.
> 
> That's not actually true, if the sysctl check code warns in any way the
> sysctl file doesn't show up in /proc/sys/

Oh, you're right. Well, it's been fixed now anyway. :-)


-Olof