From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linuxppc-dev@ozlabs.org, Greg KH <gregkh@suse.de>,
linux-usb-devel@lists.sourceforge.net,
dbrownell@users.sourceforge.net
Subject: Re: [linux-usb-devel] [PATCH 1/5] USB: Make usb_hcd_irq work for multi-role USB controllers w/ shared irq
Date: Sat, 24 Nov 2007 10:15:17 -0700 [thread overview]
Message-ID: <fa686aa40711240915k197a2af9p57ecd9605608dd4e@mail.gmail.com> (raw)
In-Reply-To: <20071124170307.773d7317@the-village.bc.nu>
On 11/24/07, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Fri, 23 Nov 2007 21:10:39 -0800
> Greg KH <gregkh@suse.de> wrote:
>
> > On Fri, Nov 23, 2007 at 05:24:31PM -0700, Grant Likely wrote:
> > > From: Peter Korsgaard <peter.korsgaard@barco.com>
> > >
> > > Some multi-role (host/peripheral) USB controllers use a shared interrupt
> > > line for all parts of the chip. Export usb_hcd_irq so drivers can call it
> > > from their interrupt handler instead of duplicating code.
> > > Drivers pass an irqnum of 0 to usb_add_hcd to signal that the interrupt handler
> > > shouldn't be registerred by the core.
> >
> > What about for platforms where irq 0 is a valid irq?
>
> There are no such platforms. Linus made that absolutely clear every time
> this came up before
>
> 0 - No IRQ
>
> A platform with a physical or bus IRQ of 0 needs to remap it to a
> different constant.
Regardless, I should probably use the NO_IRQ macro instead.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-11-24 17:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-24 0:24 [PATCH 0/5] Review request: Cypress c67x00 OTG controller Grant Likely
2007-11-24 0:24 ` [PATCH 1/5] USB: Make usb_hcd_irq work for multi-role USB controllers w/ shared irq Grant Likely
2007-11-24 5:10 ` Greg KH
2007-11-24 17:03 ` [linux-usb-devel] " Alan Cox
2007-11-24 17:15 ` Grant Likely [this message]
2007-11-24 17:50 ` David Brownell
2007-11-24 19:06 ` David Brownell
2007-11-24 19:28 ` Grant Likely
2007-11-24 0:24 ` [PATCH 2/5] USB: Add Cypress c67x00 low level interface code Grant Likely
2007-11-24 19:39 ` David Brownell
2007-11-24 0:24 ` [PATCH 3/5] USB: add Cypress c67x00 OTG controller core driver Grant Likely
2007-11-24 0:24 ` [PATCH 4/5] USB: add Cypress c67x00 OTG controller HCD driver Grant Likely
2007-11-24 3:56 ` [linux-usb-devel] " Alan Stern
2007-11-24 0:24 ` [PATCH 5/5] USB: Add Cypress c67x00 OTG controller driver to Kconfig and Makefiles Grant Likely
2007-11-24 20:12 ` David Brownell
2007-11-24 20:20 ` Grant Likely
2007-11-24 21:03 ` David Brownell
2007-11-24 21:13 ` Grant Likely
2007-11-24 17:57 ` [PATCH 0/5] Review request: Cypress c67x00 OTG controller David Brownell
2007-11-24 19:27 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40711240915k197a2af9p57ecd9605608dd4e@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).