From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glikely@secretlab.ca>
Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.244])
	by ozlabs.org (Postfix) with ESMTP id 0DE80DDED2
	for <linuxppc-dev@ozlabs.org>; Thu,  6 Dec 2007 04:39:06 +1100 (EST)
Received: by an-out-0708.google.com with SMTP id c37so1022460anc
	for <linuxppc-dev@ozlabs.org>; Wed, 05 Dec 2007 09:39:06 -0800 (PST)
Message-ID: <fa686aa40712050938j2d286655o94534a00131872e2@mail.gmail.com>
Date: Wed, 5 Dec 2007 10:38:38 -0700
From: "Grant Likely" <grant.likely@secretlab.ca>
Sender: glikely@secretlab.ca
To: "Jon Loeliger" <jdl@freescale.com>
Subject: Re: [PATCH] Add aliases node to 8641hpcn DTS file.
In-Reply-To: <1196875970.8544.12.camel@ld0161-tx32>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
References: <1196875970.8544.12.camel@ld0161-tx32>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On 12/5/07, Jon Loeliger <jdl@freescale.com> wrote:
>
> The addition of the aliases node is needed for U-Boot
> and, eventually, cuImage, to help locate the proper
> nodes reliably when using the libfdt approach.
>
> Signed-off-by: Jon Loeliger <jdl@freescale.com>
> ---
>  arch/powerpc/boot/dts/mpc8641_hpcn.dts |   28 ++++++++++++++++++++--------
>  1 files changed, 20 insertions(+), 8 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> index abb26dc..b039f21 100644
> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> @@ -16,6 +16,17 @@
>         #address-cells = <1>;
>         #size-cells = <1>;
>
> +       aliases {
> +               ethernet0 = &enet0;
> +               ethernet1 = &enet1;
> +               ethernet2 = &enet2;
> +               ethernet3 = &enet3;
> +               serial0 = &serial0;
> +               serial1 = &serial1;
> +               pci0 = &pci0;
> +               pci1 = &pci1;
> +       };

I had thought aliases were supposed to be full paths to nodes instead
of phandles.  Was I wrong?

> +
>         cpus {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> @@ -107,7 +118,7 @@
>                         };
>                 };
>
> -               ethernet@24000 {
> +               enet0: ethernet@24000 {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>                         device_type = "network";
> @@ -127,7 +138,7 @@
>                         phy-connection-type = "rgmii-id";
>                 };
>
> -               ethernet@25000 {
> +               enet1: ethernet@25000 {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>                         device_type = "network";
> @@ -147,7 +158,7 @@
>                         phy-connection-type = "rgmii-id";
>                 };
>
> -               ethernet@26000 {
> +               enet2: ethernet@26000 {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>                         device_type = "network";
> @@ -167,7 +178,7 @@
>                         phy-connection-type = "rgmii-id";
>                 };
>
> -               ethernet@27000 {
> +               enet3: ethernet@27000 {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>                         device_type = "network";
> @@ -186,7 +197,8 @@
>                         phy-handle = <&phy3>;
>                         phy-connection-type = "rgmii-id";
>                 };
> -               serial@4500 {
> +
> +               serial0: serial@4500 {
>                         device_type = "serial";
>                         compatible = "ns16550";
>                         reg = <4500 100>;
> @@ -195,7 +207,7 @@
>                         interrupt-parent = <&mpic>;
>                 };
>
> -               serial@4600 {
> +               serial1: serial@4600 {
>                         device_type = "serial";
>                         compatible = "ns16550";
>                         reg = <4600 100>;
> @@ -222,7 +234,7 @@
>                 };
>         };
>
> -       pcie@f8008000 {
> +       pci0: pcie@f8008000 {
>                 compatible = "fsl,mpc8641-pcie";
>                 device_type = "pci";
>                 #interrupt-cells = <1>;
> @@ -430,7 +442,7 @@
>
>         };
>
> -       pcie@f8009000 {
> +       pci1: pcie@f8009000 {
>                 compatible = "fsl,mpc8641-pcie";
>                 device_type = "pci";
>                 #interrupt-cells = <1>;
> --
> 1.5.2.1.126.g6abd0
>
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195