From: "Grant Likely" <grant.likely@secretlab.ca>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, sr@denx.de, monstr@monstr.eu,
jwilliams@itee.uq.edu.au, stephen.neuendorffer@xilinx.com
Subject: Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support
Date: Wed, 19 Dec 2007 23:30:16 -0700 [thread overview]
Message-ID: <fa686aa40712192230p206cc716rd85e21cb8d2bdde4@mail.gmail.com> (raw)
In-Reply-To: <20071220062348.16448.24575.stgit@trillian.secretlab.ca>
On 12/19/07, Grant Likely <grant.likely@secretlab.ca> wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Please review and comment. This patch works in my setup, but I haven't
> tested exhaustively yet. I also need to fixup the documentation to
> reflect new states before I request this patch to be merged.
>
> Question for the block layer experts: I'm using add_disk()/del_gendisk()
> functions to inform the kernel of media insertion and removal events. Is
> this the best way to do this? I looked at the .media_changed and
> .revalidate_disk hooks, but it doesn't seem like they offer the driver
> any way to notify the kernel of media removal (as opposed to the kernel
> asking the driver)
Heh, actually I *know* I'm doing the wrong thing; but I'm hoping I've
got better chances of getting steered in the right direction if I
start by throwing code out there. Currently this patch handles
insertion/removal just fine if nothing is mounted, but gets stuck if
the disk is in use. How do I get the kernel to cancel all pending
requests when deregistering the device?
Thanks,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-12-20 6:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 6:23 [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support Grant Likely
2007-12-20 6:30 ` Grant Likely [this message]
2007-12-20 14:45 ` Andy Whitcroft
2007-12-20 15:42 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40712192230p206cc716rd85e21cb8d2bdde4@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=axboe@kernel.dk \
--cc=jwilliams@itee.uq.edu.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=monstr@monstr.eu \
--cc=sr@denx.de \
--cc=stephen.neuendorffer@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).