From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.248]) by ozlabs.org (Postfix) with ESMTP id 433CDDDDFC for ; Thu, 20 Dec 2007 17:30:17 +1100 (EST) Received: by an-out-0708.google.com with SMTP id c37so900218anc.78 for ; Wed, 19 Dec 2007 22:30:16 -0800 (PST) Message-ID: Date: Wed, 19 Dec 2007 23:30:16 -0700 From: "Grant Likely" Sender: glikely@secretlab.ca To: axboe@kernel.dk, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, sr@denx.de, monstr@monstr.eu, jwilliams@itee.uq.edu.au, stephen.neuendorffer@xilinx.com Subject: Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support In-Reply-To: <20071220062348.16448.24575.stgit@trillian.secretlab.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20071220062348.16448.24575.stgit@trillian.secretlab.ca> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/19/07, Grant Likely wrote: > From: Grant Likely > > Please review and comment. This patch works in my setup, but I haven't > tested exhaustively yet. I also need to fixup the documentation to > reflect new states before I request this patch to be merged. > > Question for the block layer experts: I'm using add_disk()/del_gendisk() > functions to inform the kernel of media insertion and removal events. Is > this the best way to do this? I looked at the .media_changed and > .revalidate_disk hooks, but it doesn't seem like they offer the driver > any way to notify the kernel of media removal (as opposed to the kernel > asking the driver) Heh, actually I *know* I'm doing the wrong thing; but I'm hoping I've got better chances of getting steered in the right direction if I start by throwing code out there. Currently this patch handles insertion/removal just fine if nothing is mounted, but gets stuck if the disk is in use. How do I get the kernel to cancel all pending requests when deregistering the device? Thanks, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195