From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hs-out-2122.google.com (hs-out-0708.google.com [64.233.178.243]) by ozlabs.org (Postfix) with ESMTP id 60B17DDECA for ; Sat, 22 Dec 2007 07:50:11 +1100 (EST) Received: by hs-out-2122.google.com with SMTP id x43so495105hsb.9 for ; Fri, 21 Dec 2007 12:50:10 -0800 (PST) Message-ID: Date: Fri, 21 Dec 2007 13:50:10 -0700 From: "Grant Likely" Sender: glikely@secretlab.ca To: avorontsov@ru.mvista.com Subject: Re: [PATCH 0/4] PowerPC: implement GPIO API In-Reply-To: <20071221202824.GA4607@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20071221202824.GA4607@localhost.localdomain> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/21/07, Anton Vorontsov wrote: > Also, in the upcoming kernels, there will be GPIOLIB[1] addition to > the generic GPIO API, to support off-chip GPIO expanders (like MFDs > on I2C/LBC). But so far we support on-chip GPIOs only, with single > controller built-in. > > Changes since RFC: > - Implemented #gpio-cells handling; > - Per-bank spinlocks removed; > - Added a patch which implements GPIO API for CPM1; > - Few minor fixes. Also need to add documentation to booting-without-of.txt. In general this looks like a good direction, but I do not like the hard linking for QE and CPM gpios to the 'top level' gpio API. I think I'd prefer this stuff to stay out of mainline until the gpiolib stuff gets merged (which should be soon IIRC). Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195