From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Scott Wood" <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Li Yang <leoli@freescale.com>, paulus@samba.org
Subject: Re: [PATCH 1/3] add default device trees for MPC837x MDS board
Date: Tue, 8 Jan 2008 10:53:32 -0700 [thread overview]
Message-ID: <fa686aa40801080953y14ecdc60i8c2418ba8d6e809a@mail.gmail.com> (raw)
In-Reply-To: <20080108173845.GA5188@loki.buserror.net>
On 1/8/08, Scott Wood <scottwood@freescale.com> wrote:
> On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote:
> > On 1/7/08, Li Yang <leoli@freescale.com> wrote:
> > > + phy_type = "utmi_wide";
> >
> > fsl,phy_type please.
>
> Again, code will break. Can we stop ambushing people submitting board
> support with complaints against existing, non-board-specific code/device
> trees? Fix that first, then complain if new code reintroduces the crud.
I disagree (about bringing up these comments). New board port is the
time to bring these issue up. It keeps the issue in the forefront so
it actually gets fixed.
>
> Also, if we're going to change the property name, we should also change the
> underscore to a dash.
Good point, I missed that
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-01-08 17:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 12:03 [PATCH 1/3] add default device trees for MPC837x MDS board Li Yang
2008-01-07 12:03 ` [PATCH 2/3] add MPC837x USB platform support Li Yang
2008-01-07 12:03 ` [PATCH 3/3] USB device tree cleanups Li Yang
2008-01-07 23:10 ` Stephen Rothwell
2008-01-08 3:32 ` Li Yang
2008-01-07 23:05 ` [PATCH 2/3] add MPC837x USB platform support Stephen Rothwell
2008-01-08 7:36 ` [PATCH 1/3] add default device trees for MPC837x MDS board Kumar Gala
2008-01-08 7:57 ` Li Yang
2008-01-08 15:18 ` Kumar Gala
2008-01-08 15:58 ` Grant Likely
2008-01-08 17:38 ` Scott Wood
2008-01-08 17:53 ` Grant Likely [this message]
2008-01-09 8:38 ` Li Yang
2008-01-09 23:42 ` David Gibson
2008-01-10 0:59 ` Grant Likely
2008-01-18 6:31 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40801080953y14ecdc60i8c2418ba8d6e809a@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).