From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ag-out-0708.google.com (ag-out-0708.google.com [72.14.246.240]) by ozlabs.org (Postfix) with ESMTP id 1A648DE1C3 for ; Thu, 10 Jan 2008 03:44:59 +1100 (EST) Received: by ag-out-0708.google.com with SMTP id 33so225437agc.0 for ; Wed, 09 Jan 2008 08:44:55 -0800 (PST) Message-ID: Date: Wed, 9 Jan 2008 09:44:55 -0700 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Matt Sealey" Subject: Re: add phy-handle property for fec_mpc52xx In-Reply-To: <4784F7D1.1050301@genesi-usa.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20080109140608.GA15673@aepfle.de> <4784E78C.40904@genesi-usa.com> <4784F7D1.1050301@genesi-usa.com> Cc: linuxppc-dev@ozlabs.org, Olaf Hering List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 1/9/08, Matt Sealey wrote: > > However, I'm still inclined to pick up Olaf's patch with the > > appropriate protections around it so it is only done if the nodes are > > missing. > > Eh.. yeah. Maybe. Seems like a cop-out to me. I would rather you removed > the patch and called us a bunch of idiots for coding bad firmware, than > have the fixups be dependant on what could turn into a very well coded > but essentially screen-long list of fixups for myriad firmware versions > where the properties may or may not be present or correct for various > firmware versions and devices. I've come to the conclusion that Postel knew what he was talking about; "Be conservative in what you do; be liberal in what you accept from others." :-) I 100% agree that this stuff is better done in firmware. However, until that stuff is in place; it is 100% reasonable and desirable to work around it in prom_init. That being said, I will modify prom_init to not blindly apply fixups if they have already been done in firmware. > Grant, are you any good at coding firmware-level stuff without utilizing > any preexisting code under the GPL? I'd like to collaborate on an installer > tool which can put efika.forth (and therefore all these fixes) in. I'm good at firmware stuff, but time comes at a premium. This level of work would require a contract arrangement between our two companies. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.