Re: [PATCH] [POWERPC] Update TQM5200, CM5200 and Motion-PRO _defconfig and .dts files

["Grant Likely" <grant.likely@secretlab.ca>]

On 1/17/08, Marian Balakowicz <m8@semihalf.com> wrote:
> Grant Likely wrote:
> > On 1/17/08, Marian Balakowicz <m8@semihalf.com> wrote:
> >> Updates include:
> >> - set soc node compatible property to "fsl,mpc5200-immr"
> >
> > On these three boards; which have the original mpc5200 and which have
> > the mpc5200b?
>
> cm5200 and motionpro have mpc5200b, some versions of tqm5200 have
> mpc5200, some have mpc5200b.
>
> > I'm not going to pick up this patch immediately, I've got an invasive
> > set of mpc5200 device tree cleanups which need to go in first.  After
> > that I'll revisit your changes here.
>
> Understood, thanks.
>
> >> - update i2c device tree nodes
> >> - add mdio node
> >> - add lpb bus node and flash device (without partitions defined)
> >> - add second mscan node for Motio-PRO
> >> - add rtc i2c nodes and enable RTC in _defconfigs
> >> - use SLUB insteand of SLAB
> >> - enable printk timestamp
> >
> > Can you split the defconfig changes into a separate patch...  That
> > being said, how do you feel about merging all the 5200 defconfigs into
> > a single defconfig?  They are all multiplatform after all and it would
> > make maintenance easier.
>
> Ok, I'll split it into two patches.
>
> But merging defconfigs won't be a good option, boards differ in which
> devices they use, some have PCI, some have USB, etc. Having one
> defconfig, it would be necessary to manually customize kernel
> configuration and remember which options are to be set/disabled.

That doesn't matter for defconfigs.  That needs to be done when you're
tailoring a product regardless.  defconfigs are simply a known good
configuration; they are not intended to be the deployed config.  If
the defconfig enables all features used by any of the boards then it
should be okay.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.