From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Olaf Hering" <olaf@aepfle.de>
Cc: linuxppc-dev@ozlabs.org, Paul Mackeras <paulus@samba.org>
Subject: Re: [PATCH] autodetect serial console on efika
Date: Mon, 21 Jan 2008 11:45:34 -0700 [thread overview]
Message-ID: <fa686aa40801211045w7644cfc5tf11024bd0010b308@mail.gmail.com> (raw)
In-Reply-To: <20080121152900.GA8664@aepfle.de>
On 1/21/08, Olaf Hering <olaf@aepfle.de> wrote:
>
> Efika boards have to be booted with console=ttyPSC0 unless there is a
> graphics card plugged in. Detect if the firmware stdout is the serial
> connector.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Hrrrum; I think this is a good idea, but I'm not thrilled with the
approach. Here are my concerns:
- Determining that linux,stdout-path points to a PSC should should be
done in common code. It's useful for all 5200 boards, not just the
Efika. (However, if 'failsafe' processing is efika specific, then it
can stay in efika.c). This might be best done within the PSC driver
itself, but I'm not sure.
- Recognizing a psc node should be done by inspecting the compatible
property, not by device_type and model properties.
Thanks,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-01-21 18:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-31 15:08 [PATCH] autodetect serial console on efika Olaf Hering
2007-03-31 17:06 ` Grant Likely
2007-04-09 12:56 ` Matt Sealey
2007-04-10 16:52 ` Olaf Hering
2007-04-10 20:25 ` Sylvain Munaut
2007-04-11 6:17 ` Olaf Hering
2007-04-11 18:47 ` Matt Sealey
2007-04-11 18:42 ` Matt Sealey
2007-04-12 15:59 ` Olaf Hering
2007-04-13 9:50 ` Matt Sealey
2008-01-21 15:29 ` Olaf Hering
2008-01-21 15:37 ` [PATCH] autodetect serial console on pegasos2 Olaf Hering
2008-01-21 15:56 ` [PATCH] autodetect serial console on efika Geert Uytterhoeven
2008-01-21 16:09 ` Andreas Schwab
2008-01-21 18:45 ` Grant Likely [this message]
2008-01-21 20:34 ` Olaf Hering
2008-01-21 20:38 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40801211045w7644cfc5tf11024bd0010b308@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).