From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.250]) by ozlabs.org (Postfix) with ESMTP id ED4CADDE38 for ; Tue, 22 Jan 2008 07:38:17 +1100 (EST) Received: by an-out-0708.google.com with SMTP id c37so508047anc.78 for ; Mon, 21 Jan 2008 12:38:16 -0800 (PST) Message-ID: Date: Mon, 21 Jan 2008 13:38:16 -0700 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Olaf Hering" Subject: Re: [PATCH] autodetect serial console on efika In-Reply-To: <20080121203459.GA9967@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20070331150823.GA25421@aepfle.de> <20080121152900.GA8664@aepfle.de> <20080121203459.GA9967@aepfle.de> Cc: linuxppc-dev@ozlabs.org, Paul Mackeras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 1/21/08, Olaf Hering wrote: > On Mon, Jan 21, Grant Likely wrote: > > > On 1/21/08, Olaf Hering wrote: > > > > > > Efika boards have to be booted with console=ttyPSC0 unless there is a > > > graphics card plugged in. Detect if the firmware stdout is the serial > > > connector. > > > > > > Signed-off-by: Olaf Hering > > > > Hrrrum; I think this is a good idea, but I'm not thrilled with the > > approach. Here are my concerns: > > > > - Determining that linux,stdout-path points to a PSC should should be > > done in common code. It's useful for all 5200 boards, not just the > > Efika. (However, if 'failsafe' processing is efika specific, then it > > can stay in efika.c). This might be best done within the PSC driver > > itself, but I'm not sure. > > - Recognizing a psc node should be done by inspecting the compatible > > property, not by device_type and model properties. > > I dont have any other 5200 hardware to test a different patch. > Please improve my version and submit it for inclusion. Heh; that's okay, I and others can test on other hardware; but it's still appropriate for you to move the matching code into the PSC driver proper. Otherwise, getting it in to mainline for 2.6.25 depends on how much time I get free in the next 2 weeks. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.