linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Scott Wood" <scottwood@freescale.com>
Cc: arnd@arndb.de, linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH v3] [POWERPC] bootwrapper: build multiple cuImages
Date: Wed, 6 Feb 2008 10:17:34 -0700	[thread overview]
Message-ID: <fa686aa40802060917x3a1a9f58l21a4461f9213fcf1@mail.gmail.com> (raw)
In-Reply-To: <47A9E8AB.1050804@freescale.com>

On 2/6/08, Scott Wood <scottwood@freescale.com> wrote:
> > -ifneq ($(CONFIG_REDBOOT),"")
> > -image-$(CONFIG_PPC_8xx)                      += zImage.redboot-8xx
> > -endif
> > +# Board ports in arch/powerpc/platform/8xx/Kconfig
> > +image-$(CONFIG_PPC_MPC86XADS)                += cuImage.mpc866ads
> > +image-$(CONFIG_PPC_MPC885ADS)                += zImage-dtb.mpc885ads
>
> mpc885ads is cuImage.

Fixed

>
> > +# Board ports in arch/powerpc/platform/83xx/Kconfig
> > +image-$(CONFIG_MPC8313_RDB)          += cuImage.mpc8313erdb
>
> I don't think we need cuImage for this board (no pre-device-tree u-boot).

removed

>
> > +image-$(CONFIG_MPC837x_MDS)          += cuImage.mpc8377_mds \
> > +                                        cuImage.mpc8378_mds \
> > +                                        cuImage.mpc8379_mds
>
> I really hope we don't need cuImage for these. :-)

removed

>
> I wish CONFIG_BOARD_FOO could be annotated with properties such as image
>    name and bootwrapper platform, rather than having to maintain
> separate lists...  Oh well.

Me too.  Fortunately this is probably only an issue for images which
require an embedded dtb.  Images that get their device trees from
elsewhere can follow the lead of CONFIG_DEFAULT_UIMAGE.  Over time
this issue will diminish.

Thanks for the feedback

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2008-02-06 17:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 16:48 [PATCH v3] [POWERPC] bootwrapper: build multiple cuImages Grant Likely
2008-02-06 17:04 ` Scott Wood
2008-02-06 17:17   ` Grant Likely [this message]
2008-02-06 18:06 ` Geoff Levand
2008-02-06 18:21   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40802060917x3a1a9f58l21a4461f9213fcf1@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=arnd@arndb.de \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).