linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Pavel Kiryukhin" <pkiryukhin@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] booting-without-of: add Xilinx uart 16550.
Date: Fri, 15 Feb 2008 11:38:22 -0700	[thread overview]
Message-ID: <fa686aa40802151038l7488293clb0c47da5b1b1e4fc@mail.gmail.com> (raw)
In-Reply-To: <47B59631.10908@ru.mvista.com>

On Fri, Feb 15, 2008 at 6:40 AM, Pavel Kiryukhin
<pkiryukhin@ru.mvista.com> wrote:
> Add uart 16550 properties description to Xilinx portion of booting-without-of.txt
>
>  Signed-off-by: Pavel Kiryukhin <pkiryukhin@ru.mvista.com>
>  ---
>   Documentation/powerpc/booting-without-of.txt |   16 ++++++++++++++--
>   1 files changed, 14 insertions(+), 2 deletions(-)
>
>  diff --git a/Documentation/powerpc/booting-without-of.txt b/Documentation/powerpc/booting-without-of.txt
>  index 7b4e8a7..dd77bbc 100644
>  --- a/Documentation/powerpc/booting-without-of.txt
>  +++ b/Documentation/powerpc/booting-without-of.txt
>  @@ -2575,10 +2575,22 @@ platforms are moved over to use the flattened-device-tree model.
>
>        Xilinx uartlite devices are simple fixed speed serial ports.
>
>  -      Requred properties:
>  +      Required properties:
>         - current-speed : Baud rate of uartlite
>
>  -      v) Xilinx hwicap
>  +      v) Xilinx Uart 16550
>  +
>  +      Xilinx uart 16550 device registers are compatible with all standard 16540
>  +      and 16550 UARTs.

Not strictly true; the xilinx uart is *almost* compatible with the
ns16550.  The same driver can be made to work, but it is not register
level compatible so we cannot claim compatible="ns16550".  We need a
new compatible property for 16550 like devices with a reg shift and
offset.  Instead of attempting to come up with a generic description
of this, I recommend just naming it after the actual device instance;
something like compatible="xlnx,opb-uart16550";

Cheers,
g.

  parent reply	other threads:[~2008-02-15 18:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 13:40 [PATCH] booting-without-of: add Xilinx uart 16550 Pavel Kiryukhin
2008-02-15 17:08 ` Stephen Neuendorffer
2008-02-15 17:41   ` Pavel Kiryukhin
2008-02-15 17:46     ` Stephen Neuendorffer
2008-02-15 18:34 ` Milton Miller
2008-02-15 18:38 ` Grant Likely [this message]
2008-02-15 18:56   ` Sergei Shtylyov
2008-02-15 19:02     ` Grant Likely
2008-02-15 19:14       ` Sergei Shtylyov
2008-02-15 19:33         ` Grant Likely
2008-02-15 21:40     ` Stephen Neuendorffer
2008-02-18 19:47       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40802151038l7488293clb0c47da5b1b1e4fc@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=pkiryukhin@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).