From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.250]) by ozlabs.org (Postfix) with ESMTP id F32F8DDF08 for ; Tue, 19 Feb 2008 05:31:20 +1100 (EST) Received: by an-out-0708.google.com with SMTP id c37so1817946anc.78 for ; Mon, 18 Feb 2008 10:31:19 -0800 (PST) Message-ID: Date: Mon, 18 Feb 2008 11:31:19 -0700 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Sean MacLennan" Subject: Re: arch_initcall time In-Reply-To: <47B9CE4D.1020303@pikatech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <47B9CE4D.1020303@pikatech.com> Cc: LinuxPPC-dev List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Feb 18, 2008 11:28 AM, Sean MacLennan wrote: > I need to call i2c_register_board_info for the new i2c style ad7414 > driver. This needs to be called at arch initcall time. Currently I just > do this: > > static int __init warp_arch_init(void) > { > i2c_register_board_info(0, warp_i2c_info, ARRAY_SIZE(warp_i2c_info)); > return 0; > } > arch_initcall(warp_arch_init); Yes, this is the right thing to do, but use machine_arch_initcall() instead so that it doesn't get called if it is not your board. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.