powerpc: cuImage.* creation error

powerpc: cuImage.* creation error

[Adrian Bunk]

When building all powerpc defconfigs in 2.6.25-rc6 exactly three of 
them fail to build, and all with similar problems:


mpc85xx_defconfig:

<--  snip  -->

...
  WRAP    arch/powerpc/boot/cuImage.tqm8540
DTC: dts->dtb  on file "/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/dts/tqm8540.dts"
powerpc64-linux-ld: arch/powerpc/boot/cuboot-tqm8540.o: No such file: No such file or directory
make[2]: *** [arch/powerpc/boot/cuImage.tqm8540] Error 1

<--  snip  -->


sbc8548_defconfig:

<--  snip  -->

...
Entry Point:  0x00000000
make[2]: *** No rule to make target `arch/powerpc/boot/cuImage.tqm8548', needed by `arch/powerpc/boot/zImage'.  Stop.

<--  snip  -->


tqm8540_defconfig:

<--  snip  -->

...
  WRAP    arch/powerpc/boot/cuImage.tqm8540
DTC: dts->dtb  on file "/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/dts/tqm8540.dts"
powerpc64-linux-ld: arch/powerpc/boot/cuboot-tqm8540.o: No such file: No such file or directory
make[2]: *** [arch/powerpc/boot/cuImage.tqm8540] Error 1

<--  snip  -->


Is this a problem on my side or is there a bug that should be fixed?


TIA
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: powerpc: cuImage.* creation error

[Grant Likely]

On Mon, Mar 17, 2008 at 1:36 PM, Adrian Bunk <bunk@kernel.org> wrote:
> When building all powerpc defconfigs in 2.6.25-rc6 exactly three of
>  them fail to build, and all with similar problems:
>
>  powerpc64-linux-ld: arch/powerpc/boot/cuboot-tqm8540.o: No such file: No such file or directory
>  make[2]: *** No rule to make target `arch/powerpc/boot/cuImage.tqm8548', needed >  powerpc64-linux-ld: arch/powerpc/boot/cuboot-tqm8540.o: No such file: No such file or directory
>  make[2]: *** [arch/powerpc/boot/cuImage.tqm8540] Error 1
>
>  Is this a problem on my side or is there a bug that should be fixed?

I may have messed something up.  I'll dig into it this afternoon.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: powerpc: cuImage.* creation error

[Paul Gortmaker]

In message: powerpc: cuImage.* creation error
on 17/03/2008 Adrian Bunk wrote:

> When building all powerpc defconfigs in 2.6.25-rc6 exactly three of 
> them fail to build, and all with similar problems:
> 
> <--  snip  -->
> 
> 
> sbc8548_defconfig:
> 
> <--  snip  -->
> 
> ...
> Entry Point:  0x00000000
> make[2]: *** No rule to make target `arch/powerpc/boot/cuImage.tqm8548', needed by `arch/powerpc/boot/zImage'.  Stop.
> 

Untested, but I'll guess that this is at least part of the problem for
the sbc one...

Thanks,
Paul.

---

Author: Paul Gortmaker <paul.gortmaker@windriver.com>
Date:   Mon Mar 17 15:47:03 2008 -0400

    cuimage: fix board names in Makefile
    
    Fix the copy and paste error from 25431333813686654907ab987fb5de10c10a16db
    for the sbc8548 and sbc8560
    
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 4974d9e..1aded8f 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -253,8 +253,8 @@ image-$(CONFIG_TQM8540)			+= cuImage.tqm8540
 image-$(CONFIG_TQM8541)			+= cuImage.tqm8541
 image-$(CONFIG_TQM8555)			+= cuImage.tqm8555
 image-$(CONFIG_TQM8560)			+= cuImage.tqm8560
-image-$(CONFIG_SBC8548)			+= cuImage.tqm8548
-image-$(CONFIG_SBC8560)			+= cuImage.tqm8560
+image-$(CONFIG_SBC8548)			+= cuImage.sbc8548
+image-$(CONFIG_SBC8560)			+= cuImage.sbc8560
 
 # Board ports in arch/powerpc/platform/embedded6xx/Kconfig
 image-$(CONFIG_STORCENTER)		+= cuImage.storcenter

Re: powerpc: cuImage.* creation error

[Adrian Bunk]

On Mon, Mar 17, 2008 at 04:07:55PM -0400, Paul Gortmaker wrote:
> In message: powerpc: cuImage.* creation error
> on 17/03/2008 Adrian Bunk wrote:
> 
> > When building all powerpc defconfigs in 2.6.25-rc6 exactly three of 
> > them fail to build, and all with similar problems:
> > 
> > <--  snip  -->
> > 
> > 
> > sbc8548_defconfig:
> > 
> > <--  snip  -->
> > 
> > ...
> > Entry Point:  0x00000000
> > make[2]: *** No rule to make target `arch/powerpc/boot/cuImage.tqm8548', needed by `arch/powerpc/boot/zImage'.  Stop.
> > 
> 
> Untested, but I'll guess that this is at least part of the problem for
> the sbc one...

It doesn't fix the build, and adds sbc8560_defconfig to the list of 
non-compiling defconfigs:

<--  snip  -->

...
  WRAP    arch/powerpc/boot/cuImage.sbc8560
DTC: dts->dtb  on file "/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/dts/sbc8560.dts"
powerpc64-linux-ld: arch/powerpc/boot/cuboot-sbc8560.o: No such file: No such file or directory
make[2]: *** [arch/powerpc/boot/cuImage.sbc8560] Error 1

<--  snip  -->

> Thanks,
> Paul.
> 
> ---
> 
> Author: Paul Gortmaker <paul.gortmaker@windriver.com>
> Date:   Mon Mar 17 15:47:03 2008 -0400
> 
>     cuimage: fix board names in Makefile
>     
>     Fix the copy and paste error from 25431333813686654907ab987fb5de10c10a16db
>     for the sbc8548 and sbc8560
>     
>     Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> 
> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
> index 4974d9e..1aded8f 100644
> --- a/arch/powerpc/boot/Makefile
> +++ b/arch/powerpc/boot/Makefile
> @@ -253,8 +253,8 @@ image-$(CONFIG_TQM8540)			+= cuImage.tqm8540
>  image-$(CONFIG_TQM8541)			+= cuImage.tqm8541
>  image-$(CONFIG_TQM8555)			+= cuImage.tqm8555
>  image-$(CONFIG_TQM8560)			+= cuImage.tqm8560
> -image-$(CONFIG_SBC8548)			+= cuImage.tqm8548
> -image-$(CONFIG_SBC8560)			+= cuImage.tqm8560
> +image-$(CONFIG_SBC8548)			+= cuImage.sbc8548
> +image-$(CONFIG_SBC8560)			+= cuImage.sbc8560
>  
>  # Board ports in arch/powerpc/platform/embedded6xx/Kconfig
>  image-$(CONFIG_STORCENTER)		+= cuImage.storcenter

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: powerpc: cuImage.* creation error

[Grant Likely]

On Mon, Mar 17, 2008 at 1:36 PM, Adrian Bunk <bunk@kernel.org> wrote:
> When building all powerpc defconfigs in 2.6.25-rc6 exactly three of
>  them fail to build, and all with similar problems:
>

Looks like I added a bogus target (no dts file for the board yet) and
didn't match correctly the init code for the other two.  Please try
this:

--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -253,7 +253,6 @@ image-$(CONFIG_TQM8540)                     += cuImage.tqm85
 image-$(CONFIG_TQM8541)                        += cuImage.tqm8541
 image-$(CONFIG_TQM8555)                        += cuImage.tqm8555
 image-$(CONFIG_TQM8560)                        += cuImage.tqm8560
-image-$(CONFIG_SBC8548)                        += cuImage.tqm8548
 image-$(CONFIG_SBC8560)                        += cuImage.tqm8560

 # Board ports in arch/powerpc/platform/embedded6xx/Kconfig
diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index d50e498..511e09e 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
@@ -174,7 +174,7 @@ cuboot*)
     *-mpc83*)
         platformo=$object/cuboot-83xx.o
         ;;
-    *-tqm8541|*-mpc8560*|*-tqm8560|*-tqm8555*)
+    *-tqm854?|*-mpc8560*|*-tqm8560|*-tqm8555*)
         platformo=$object/cuboot-85xx-cpm2.o
         ;;
     *-mpc85*)


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: powerpc: cuImage.* creation error

[Grant Likely]

On Mon, Mar 17, 2008 at 2:07 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> In message: powerpc: cuImage.* creation error
>
>  @@ -253,8 +253,8 @@ image-$(CONFIG_TQM8540)                     += cuImage.tqm8540
>   image-$(CONFIG_TQM8541)                        += cuImage.tqm8541
>   image-$(CONFIG_TQM8555)                        += cuImage.tqm8555
>   image-$(CONFIG_TQM8560)                        += cuImage.tqm8560
>  -image-$(CONFIG_SBC8548)                        += cuImage.tqm8548
>  -image-$(CONFIG_SBC8560)                        += cuImage.tqm8560
>  +image-$(CONFIG_SBC8548)                        += cuImage.sbc8548
>  +image-$(CONFIG_SBC8560)                        += cuImage.sbc8560

No, the suffix in the cuImage targets has a 1:1 relationship with dts
files in arch/powerpc/boot/dts/.  If a file doesn't exist there, then
the target cannot be built.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: powerpc: cuImage.* creation error

[Paul Gortmaker]

In message: Re: powerpc: cuImage.* creation error
on 17/03/2008 Grant Likely wrote:

> On Mon, Mar 17, 2008 at 2:07 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > In message: powerpc: cuImage.* creation error
> >
> >  @@ -253,8 +253,8 @@ image-$(CONFIG_TQM8540)                     += cuImage.tqm8540
> >   image-$(CONFIG_TQM8541)                        += cuImage.tqm8541
> >   image-$(CONFIG_TQM8555)                        += cuImage.tqm8555
> >   image-$(CONFIG_TQM8560)                        += cuImage.tqm8560
> >  -image-$(CONFIG_SBC8548)                        += cuImage.tqm8548
> >  -image-$(CONFIG_SBC8560)                        += cuImage.tqm8560
> >  +image-$(CONFIG_SBC8548)                        += cuImage.sbc8548
> >  +image-$(CONFIG_SBC8560)                        += cuImage.sbc8560
> 
> No, the suffix in the cuImage targets has a 1:1 relationship with dts
> files in arch/powerpc/boot/dts/.  If a file doesn't exist there, then
> the target cannot be built.

You should have both the sbc8548.dts and the sbc8560.dts in your tree.
They have been in there for several weeks now.

I just tested with the above here, and I was just about to hit send on
this extra chunk to fix the second half of the problem.

Note that I didn't lump the tqm8540 in with the other tqm, because the
defconfig tends to indicate it doesn't need 85xx-cpm2;  just 85xx.

Thanks,
Paul.

--

Author: Paul Gortmaker <paul.gortmaker@windriver.com>
Date:   Mon Mar 17 18:33:52 2008 -0400

    wrapper: Add entries for tqm8540 and sbc85xx
    
    The wrapper script didn't have entries for the TQM8540 board and the
    SBC8548 or SBC8560 boards.  I've assumed that the TQM8540 console is
    8250 based and not CPM based by looking at its defconfig.  There was
    also a trailing * on the TQM8555 entry that I removed too.
    
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index d50e498..8ec8ea8 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
@@ -174,7 +174,10 @@ cuboot*)
     *-mpc83*)
         platformo=$object/cuboot-83xx.o
         ;;
-    *-tqm8541|*-mpc8560*|*-tqm8560|*-tqm8555*)
+    *-tqm8540|*-sbc85*)
+        platformo=$object/cuboot-85xx.o
+        ;;
+    *-tqm8541|*-mpc8560*|*-tqm8560|*-tqm8555)
         platformo=$object/cuboot-85xx-cpm2.o
         ;;
     *-mpc85*)

Re: powerpc: cuImage.* creation error

[Grant Likely]

On Mon, Mar 17, 2008 at 4:46 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> In message: Re: powerpc: cuImage.* creation error
>
>
> on 17/03/2008 Grant Likely wrote:
>
>  > On Mon, Mar 17, 2008 at 2:07 PM, Paul Gortmaker
>  > <paul.gortmaker@windriver.com> wrote:
>  > > In message: powerpc: cuImage.* creation error
>  > >
>  > >  @@ -253,8 +253,8 @@ image-$(CONFIG_TQM8540)                     += cuImage.tqm8540
>  > >   image-$(CONFIG_TQM8541)                        += cuImage.tqm8541
>  > >   image-$(CONFIG_TQM8555)                        += cuImage.tqm8555
>  > >   image-$(CONFIG_TQM8560)                        += cuImage.tqm8560
>  > >  -image-$(CONFIG_SBC8548)                        += cuImage.tqm8548
>  > >  -image-$(CONFIG_SBC8560)                        += cuImage.tqm8560
>  > >  +image-$(CONFIG_SBC8548)                        += cuImage.sbc8548
>  > >  +image-$(CONFIG_SBC8560)                        += cuImage.sbc8560
>  >
>  > No, the suffix in the cuImage targets has a 1:1 relationship with dts
>  > files in arch/powerpc/boot/dts/.  If a file doesn't exist there, then
>  > the target cannot be built.
>
>  You should have both the sbc8548.dts and the sbc8560.dts in your tree.
>  They have been in there for several weeks now.

Heh; oops.  I looked but somehow missed them.  I guess I didn't look
hard enough.

Yes, this looks like the right solution.

>  Author: Paul Gortmaker <paul.gortmaker@windriver.com>
>  Date:   Mon Mar 17 18:33:52 2008 -0400
>
>     wrapper: Add entries for tqm8540 and sbc85xx
>
>     The wrapper script didn't have entries for the TQM8540 board and the
>     SBC8548 or SBC8560 boards.  I've assumed that the TQM8540 console is
>     8250 based and not CPM based by looking at its defconfig.  There was
>     also a trailing * on the TQM8555 entry that I removed too.
>
>
>     Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>

Cheers,
g.


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: powerpc: cuImage.* creation error

[Grant Likely]

On Mon, Mar 17, 2008 at 5:22 PM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Mon, Mar 17, 2008 at 4:46 PM, Paul Gortmaker
>  >     The wrapper script didn't have entries for the TQM8540 board and the
>  >     SBC8548 or SBC8560 boards.  I've assumed that the TQM8540 console is
>  >     8250 based and not CPM based by looking at its defconfig.  There was
>  >     also a trailing * on the TQM8555 entry that I removed too.
>  >
>  >
>  >     Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>  Acked-by: Grant Likely <grant.likely@secretlab.ca>

Actually, I looked again and tweaked a few details in the patch (it
was duplicating an existing clause in the wrapper script).  I'm just
about to post the edited version which I've tested in my environment.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.