Re: [PATCH] Linux >=2.6.24 support for FEC on MPC5200 (not B!)

["Grant Likely" <grant.likely@secretlab.ca>]

On Wed, Mar 12, 2008 at 12:57 PM, Ren=E9 B=FCrgel <r.buergel@unicontrol.de>=
 wrote:
> Here is a patch for the lite5200 to get the FEC working again for kernel
>   >=3D2.6.24. It was created against Linux 2.6.24.
>
>  The FEC driver is also compatible with the MPC5200, not only with the
>  MPC5200B, so an according entry was added to the drivers matching list.
>  Furthermore the settings for the PHY were entered in the dts file for
>  the Lite5200. Note, that this is not exactly the same as in the
>  Lite5200B, because the PHY is located at f0003000:01 for the 5200, and
>  at :00 for the 5200B. I could test the patch on a Lite5200 and a
>  Lite5200B, both booted a kernel via tftp and mounted the root via nfs
>  successfully.
>  I hope, you can include the patch into the official tree.

Oops, I spoke too soon on picking this up.  The patch looks mostly
good, but it does not apply to the head of the tree.  Can you please
rebase it on top of Linus' current tree and repost?  While you're at
it, I've got a couple of minor comments below that should be
addressed:


>  +               mdio@3000 {
>  +                       #address-cells =3D <1>;
>  +                       #size-cells =3D <0>;
>  +                       device_type =3D "mdio";
Drop the device_type property

>  +                       compatible =3D "mpc5200-fec-phy";
should be "mpc5200-mdio"  (see current lite5200 for the example)

Cheers,
g.



--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.