From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Bartlomiej Sieka" <tur@semihalf.com>,
"Grant Likely" <grant.likely@secretlab.ca>,
linuxppc-dev@ozlabs.org, "Anatolij Gustschin" <agust@denx.de>,
"Paul Mackerras" <paulus@samba.org>
Subject: Re: [POWERPC] mpc52xx: Amalgamated dts fixes and updates
Date: Fri, 21 Mar 2008 21:47:25 -0600 [thread overview]
Message-ID: <fa686aa40803212047q2ab338feseeb5e277bad1a7f1@mail.gmail.com> (raw)
In-Reply-To: <20080322001242.GA29812@localhost.localdomain>
On Fri, Mar 21, 2008 at 6:12 PM, David Gibson
<david@gibson.dropbear.id.au> wrote:
> On Sat, Mar 22, 2008 at 12:56:35AM +0100, Bartlomiej Sieka wrote:
> > diff --git a/arch/powerpc/boot/dts/cm5200.dts b/arch/powerpc/boot/dts/cm5200.dts
> > index 30737ea..8b2e8e4 100644
> > --- a/arch/powerpc/boot/dts/cm5200.dts
> > +++ b/arch/powerpc/boot/dts/cm5200.dts
> > @@ -159,6 +159,7 @@
> > };
> >
> > dma-controller@1200 {
> > + device_type = "dma-controller";
>
> This is not right. If adding device_type here fixes something, then
> the driver is wrong and should be fixed instead.
I just sent a patch that fixes the driver bug.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-03-22 3:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 14:18 Oops with TQM5200 on TQM5200 Wolfgang Grandegger
2008-03-20 14:41 ` Grant Likely
2008-03-20 15:24 ` Anatolij Gustschin
2008-03-20 16:17 ` Bartlomiej Sieka
2008-03-20 21:27 ` Grant Likely
2008-03-22 10:49 ` Anatolij Gustschin
2008-03-22 14:39 ` Grant Likely
2008-03-20 16:29 ` Wolfgang Grandegger
2008-03-20 23:50 ` Grant Likely
2008-03-21 0:07 ` Bartlomiej Sieka
2008-03-21 0:20 ` Grant Likely
2008-03-21 23:56 ` [POWERPC] mpc52xx: Amalgamated dts fixes and updates Bartlomiej Sieka
2008-03-22 0:12 ` David Gibson
2008-03-22 3:47 ` Grant Likely [this message]
2008-03-22 0:41 ` Anatolij Gustschin
2008-03-22 3:14 ` Grant Likely
2008-03-26 19:45 ` [RESEND][POWERPC] mpc5200: " Bartlomiej Sieka
2008-03-26 20:35 ` Grant Likely
2008-03-26 20:48 ` Wolfgang Grandegger
2008-03-26 21:32 ` Bartlomiej Sieka
2008-03-26 21:18 ` [RESEND2][POWERPC] " Bartlomiej Sieka
2008-03-26 21:02 ` [RESEND][POWERPC] " Matt Sealey
2008-03-26 21:16 ` Grant Likely
2008-03-26 22:51 ` David Gibson
2008-03-26 22:57 ` Matt Sealey
2008-03-26 23:28 ` David Gibson
2008-03-24 16:59 ` [POWERPC] mpc52xx: " Wolfgang Grandegger
2008-03-21 6:30 ` Oops with TQM5200 on TQM5200 Wolfgang Grandegger
2008-03-21 19:02 ` Grant Likely
2008-03-24 6:47 ` Paul Mackerras
2008-03-25 9:54 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40803212047q2ab338feseeb5e277bad1a7f1@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=agust@denx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tur@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).