From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.251]) by ozlabs.org (Postfix) with ESMTP id F2620DDF6D for ; Tue, 25 Mar 2008 03:48:33 +1100 (EST) Received: by an-out-0708.google.com with SMTP id c37so614456anc.78 for ; Mon, 24 Mar 2008 09:48:32 -0700 (PDT) Message-ID: Date: Mon, 24 Mar 2008 10:48:32 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Sergei Shtylyov" Subject: Re: [PATCH 2/3] [POWERPC] Xilinx: of_serial support for Xilinx uart 16550. In-Reply-To: <47E7D3BB.1050403@ru.mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <12060242324116-git-send-email-john.linn@xilinx.com> <20080320144402.3063517C005D@mail148-sin.bigfish.com> <18403.32257.725539.470771@cargo.ozlabs.ibm.com> <47E7B61B.70708@ru.mvista.com> <47E7D3BB.1050403@ru.mvista.com> Cc: linuxppc-dev@ozlabs.org, Paul Mackerras , John Linn List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Mar 24, 2008 at 10:15 AM, Sergei Shtylyov wrote: > Grant Likely wrote: > >> Probably I misunderstood you: does it give the same result as offset 11? > > > er; typo; oops. A 32 bit read add offset 0 is the same as a byte read > > at offset *3*. > > Oh, well... unfortunately, we can't use UPIO_MEM32 "register model" in > 8250.c anyway since that makes use of readl()/writel() -- which treat the bus > as bigendian on PPC... anyway, we would need at least a "reg-size" property, > if not new "compatible"... :-) ... and the *driver* itself isn't any sort of issue; it's just figuring out the best way to describe the hardware accurately/appropriately so the binding can decide how to configure the driver. > >> Have you considered using the existing "big-endian" property? > > > No I haven't, but that would work too. I'm happy with that if it > > works for you. If the property was defined, then the byte offset to > > the first reg would be adjusted by 1^(reg-shift) - 1 > > You don't mean "xor" by ^, do you? :-O > In fact, it should be <<... heh; pseudocoding in the wrong language. You, of course, are right. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.