From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Anton Vorontsov" <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH 3/5] leds: implement OpenFirmare GPIO LEDs driver
Date: Wed, 26 Mar 2008 14:57:10 -0600 [thread overview]
Message-ID: <fa686aa40803261357m4a8e8703u7f3b8e39199e1de7@mail.gmail.com> (raw)
In-Reply-To: <20080326202453.GC1772@localhost.localdomain>
On Wed, Mar 26, 2008 at 2:24 PM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> Despite leds-gpio and leds-of-gpio similar names and purposes, there
> is actually very few code can be shared between the two (both drivers
> are mostly the driver bindings anyway).
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Other than the fact that it needs some documentation of the binding in
booting-without-of.txt, it looks pretty good to me.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-03-26 20:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 20:24 [PATCH 3/5] leds: implement OpenFirmare GPIO LEDs driver Anton Vorontsov
2008-03-26 20:57 ` Grant Likely [this message]
2008-03-26 21:04 ` Matt Sealey
2008-03-26 23:07 ` Anton Vorontsov
2008-03-27 17:10 ` Anton Vorontsov
2008-03-30 18:08 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40803261357m4a8e8703u7f3b8e39199e1de7@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).