Re: [PATCH 1/2] OF helpers for the GPIO API

["Grant Likely" <grant.likely@secretlab.ca>]

On Fri, Apr 11, 2008 at 7:06 AM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> This patch implements various helpers to support OF bindings for
>  the GPIO LIB API.
>
>  Previously this was PowerPC specific, but it seems this code
>  isn't arch-dependent anyhow, so let's place it into of/.
>
>  SPARC will not see this addition yet, real hardware seem to not use
>  GPIOs at all. But this might change:
>
>    http://www.leox.org/docs/faq_MLleon.html
>
>  "16-bit I/O port" sounds promising. :-)
>
>  Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

Looks pretty sane to me.  Only nitpick; the documentation should be part of this
patch, not the next one; but I have no complaints if they both get
picked up at the same time.

Acked-by: Grant Likely <grant.likely@secretlab.ca>

Cheers,
g.


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.