From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Robert Schwebel" <r.schwebel@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: mpc5200: add interrupt type function
Date: Wed, 16 Apr 2008 23:41:08 -0700 [thread overview]
Message-ID: <fa686aa40804162341h5e68e460t975f69118ff8beca@mail.gmail.com> (raw)
In-Reply-To: <20080417060031.GH13814@pengutronix.de>
On Wed, Apr 16, 2008 at 11:00 PM, Robert Schwebel
<r.schwebel@pengutronix.de> wrote:
> On Tue, Apr 15, 2008 at 05:29:54PM +0200, Robert Schwebel wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > Add a set_type function for external (GPIO) interrupts.
> >
> > Signed-off-by: Juergen Beisert <j.beisert@pengutronix.de>
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> As we didn't get negative feedback yet, could this go into the 2.6.26
> merge window?
I didn't see this the first time (didn't get cc'd).
It looks mostly okay, but in doesn't have any mutual exclusion which
it probably should have. What are the users of this?
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2008-04-17 6:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 15:29 mpc5200: add interrupt type function Robert Schwebel
2008-04-17 6:00 ` Robert Schwebel
2008-04-17 6:41 ` Grant Likely [this message]
2008-04-18 8:19 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40804162341h5e68e460t975f69118ff8beca@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=r.schwebel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).