Re: [RESEND][PATCH 2/2][POWERPC] PIKA Warp: Update platform code to supportRev B boards

["Grant Likely" <grant.likely@secretlab.ca>]

On Mon, Apr 28, 2008 at 7:50 PM, Sean MacLennan <smaclennan@pikatech.com> wrote:
> diff --git a/arch/powerpc/boot/dts/warp.dts b/arch/powerpc/boot/dts/warp.dts
>  index b04a52e..3e95e99 100644

You still need to have *some* kind of change log and a signed-off-by
line in this patch.  :-)

There is one minor change that needs to be added below; otherwise:

Acked-by: Grant Likely <grant.likely@secretlab.ca>

(You can add my acked-by line to the next version of this patch if
you're only changing the thing I comment on).

Josh, when he respins it I think the dts changes are ready to be picked up.

>  @@ -186,18 +179,45 @@
>                         GPIO1: gpio@ef600c00 {
>                                 compatible = "ibm,gpio-440ep";
>                                 reg = <ef600c00 48>;
>  +                               #gpio-cells = <2>;
>  +                               gpio-controller;
>  +
>  +                               led@31 {
>
> +                                       compatible = "linux,gpio-led";
>  +                                       linux,name = ":green:";
>  +                                       gpios = <&GPIO1 31>;

Since #gpio-cells is '2'; the gpios property needs to reflect that.
It should be:

gpios = <&GPIO1 31 0>;

The second cell the GPIO controller would use for flags (inverted,
open-drain, etc).

>  +                               };
>  +
>  +                               led@30 {
>  +                                       compatible = "linux,gpio-led";
>  +                                       linux,name = ":red:";
>  +                                       gpios = <&GPIO1 30>;

ditto

>  +                               };
>
>
>                         };
>

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.