Re: [PATCH] [POWERPC] mpc5200: Allow for fixed speed MII configurations

["Grant Likely" <grant.likely@secretlab.ca>]

On Thu, May 1, 2008 at 10:38 AM, Wolfgang Grandegger <wg@grandegger.com> wrote:
> Hi Grant,
>
>
>  Grant Likely wrote:
>  > On Tue, Apr 29, 2008 at 5:06 PM, Grant Likely <grant.likely@secretlab.ca> wrote:
>  >> From: Grant Likely <grant.likely@secretlab.ca>
>  >>
>  >>  Various improvements for configuring the MPC5200 MII link from the
>  >>  device tree:
>  >>  * Look for 'current-speed' property for fixed speed MII links
>  >>  * Look for 'fsl,7-wire-mode' property for boards using the 7 wire mode
>  >>  * move definition of private data structure out of the header file
>  >>
>  >>  Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
>  >
>  > Any more comments on this patch?  I want to push it to Paulus, but I'd
>  > like to have someone ack it first.
>  >
>  > Wolfgang, you used the previous version of this patch.  Does this one
>  > work for you?
>
>  Sorry for the late answer. The patch works fine (under Linux 2.6.24) on
>  my board with a 3-port Micrel ethernet switch. There is still a minor
>  issue, though:
>
>  >>  -               of_node_put(phy_dn);
>  >>  +       /* Start with safe defaults for link connection */
>  >>  +       priv->phy_addr = FEC5200_PHYADDR_NONE;
>  >>  +       priv->speed = 100;
>  >>  +       priv->duplex = 0;
>
>  priv->duplex is re-defined here. And instead of "0" we should use
>  DUPLEX_HALF.

Oops,

Fixed.

If you reply with your 'acked-by' line, then I'll push this one to
Paul so it can get into .26

Thanks,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.